Marostegui has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/336600 )
Change subject: check_private_data.py: Add missing quote ...................................................................... check_private_data.py: Add missing quote There is a missing quote on the UPDATE statement the script returns when it find private data on a column. This is what it shows: -- UPDATE `commonswiki`.abuse_filter_log` SET `afl_ip` = NULL; Which is missing the `abuse Bug: T153743 Change-Id: Icbbb594b611c9422d40ca0e63acc5a5819dc9aa4 --- M modules/role/files/mariadb/check_private_data.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marostegui: Looks good to me, approved jenkins-bot: Verified Jcrespo: Looks good to me, but someone else must approve diff --git a/modules/role/files/mariadb/check_private_data.py b/modules/role/files/mariadb/check_private_data.py index 769be5a..475fa6c 100644 --- a/modules/role/files/mariadb/check_private_data.py +++ b/modules/role/files/mariadb/check_private_data.py @@ -179,7 +179,7 @@ on the list """ for col in cols: - print(("-- UPDATE `{}`.{}`" + print(("-- UPDATE `{}`.`{}`" " SET `{}` = NULL;").format(col[0], col[1], col[2])) -- To view, visit https://gerrit.wikimedia.org/r/336600 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbbb594b611c9422d40ca0e63acc5a5819dc9aa4 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Marostegui <maroste...@wikimedia.org> Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org> Gerrit-Reviewer: Marostegui <maroste...@wikimedia.org> Gerrit-Reviewer: Volans <rcocci...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits