Chad has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336716 )
Change subject: Log a warning when headers were already sent and we can't
......................................................................
Log a warning when headers were already sent and we can't
Change-Id: Id01f4712e3dd297594e9ed2389ad411be5f553e7
(cherry picked from commit c78d1c842f7d4306cc20ffe4123e50fcf341fe76)
---
M includes/WebResponse.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/16/336716/1
diff --git a/includes/WebResponse.php b/includes/WebResponse.php
index 339b2e3..f5fb47f 100644
--- a/includes/WebResponse.php
+++ b/includes/WebResponse.php
@@ -39,6 +39,9 @@
* @param null|int $http_response_code Forces the HTTP response code to
the specified value.
*/
public function header( $string, $replace = true, $http_response_code =
null ) {
+ if ( headers_sent() ) {
+ MWDebug::warning( 'Headers already sent, should send
headers earlier than ' . wfGetCaller() );
+ }
if ( $http_response_code ) {
header( $string, $replace, $http_response_code );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/336716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id01f4712e3dd297594e9ed2389ad411be5f553e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.29.0-wmf.11
Gerrit-Owner: Chad <ch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
