jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/336729 )
Change subject: Only load necessary fields on Special:TimedMediaHandler lists
......................................................................
Only load necessary fields on Special:TimedMediaHandler lists
Special:TimedMediaHandler's list of last 50 errors/etc was running
out of memory due to loading every field, including sometimes very
long error message dumps. When all 50 had large dumps, this caused
failure of the request.
Now only loading the two fields needed.
Bug: T157621
Change-Id: I2a2067acbda0f57e9b3dd9014aab2fe806f27ae5
---
M SpecialTimedMediaHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Paladox: Looks good to me, but someone else must approve
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php
index d929d57..36f5929 100644
--- a/SpecialTimedMediaHandler.php
+++ b/SpecialTimedMediaHandler.php
@@ -114,7 +114,7 @@
$files = [];
$res = $dbr->select(
'transcode',
- '*',
+ [ 'transcode_image_name', 'transcode_key' ],
$this->transcodeStates[ $state ],
__METHOD__,
[ 'LIMIT' => $limit, 'ORDER BY' =>
'transcode_time_error DESC' ]
--
To view, visit https://gerrit.wikimedia.org/r/336729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a2067acbda0f57e9b3dd9014aab2fe806f27ae5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
