Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336837 )
Change subject: Fix unconditional cloning in MediaInfo
......................................................................
Fix unconditional cloning in MediaInfo
Change-Id: Iefed4327d6896b6fc88e0a983e60801c70738964
---
M src/DataModel/MediaInfo.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseMediaInfo
refs/changes/37/336837/1
diff --git a/src/DataModel/MediaInfo.php b/src/DataModel/MediaInfo.php
index 385d07d..24c6f7c 100644
--- a/src/DataModel/MediaInfo.php
+++ b/src/DataModel/MediaInfo.php
@@ -157,8 +157,7 @@
public function __clone() {
$this->labels = clone $this->labels;
$this->descriptions = clone $this->descriptions;
- // TODO: DataModel 5.1 is needed to be able to use clone for
the statements.
- $this->statements = unserialize( serialize( $this->statements )
);
+ $this->statements = clone $this->statements;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/336837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefed4327d6896b6fc88e0a983e60801c70738964
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseMediaInfo
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
