jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330973 )

Change subject: onChangesListSpecialPageFilters: Actually treat namespace as an 
integer
......................................................................


onChangesListSpecialPageFilters: Actually treat namespace as an integer

Bug: T154395
Change-Id: I36ebdd70f5a4217e18dc920deeb8a7c0b84c4de2
---
M WikimediaEventsHooks.php
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 8b6f928..bafa466 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -592,8 +592,13 @@
                $webParams = $special->getRequest()->getQueryValues();
                foreach ( $webParams as $param => $value ) {
                        if ( array_key_exists( $param, $knownFilters ) && 
$value !== '' && $value !== null ) {
-                               $logData[ $param ] = $knownFilters[ $param ] 
=== 'bool' ?
-                                       (bool)$value : $value;
+                               if ( $knownFilters[ $param ] === 'bool' ) {
+                                       $logData[ $param ] = (bool)$value;
+                               } else if ( $knownFilters[ $param ] === 
'integer' ) {
+                                       $logData[ $param ] = (int)$value;
+                               } else {
+                                       $logData[ $param ] = (string)$value;
+                               }
                        }
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/330973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36ebdd70f5a4217e18dc920deeb8a7c0b84c4de2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to