Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336848 )
Change subject: Fix: try to avoid out of memory errors when detecting faces
......................................................................
Fix: try to avoid out of memory errors when detecting faces
If users are bumping against the memory limit, they will probably
experience other issues but it might be worth guarding against frequent
and non-critical OutOfMemoryErrors occurring during face detection
Change-Id: I33c46374243527b6464ea5b56b4d6625d2eaf85c
---
M app/src/main/java/org/wikipedia/views/FacePostprocessor.java
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/48/336848/1
diff --git a/app/src/main/java/org/wikipedia/views/FacePostprocessor.java
b/app/src/main/java/org/wikipedia/views/FacePostprocessor.java
index 1c41b87..90e7a2c 100644
--- a/app/src/main/java/org/wikipedia/views/FacePostprocessor.java
+++ b/app/src/main/java/org/wikipedia/views/FacePostprocessor.java
@@ -44,7 +44,12 @@
copyWithWhiteBackground(destBitmap, sourceBitmap);
Bitmap testBmp = new565ScaledBitmap(sourceBitmap);
Palette colorPalette = Palette.from(testBmp).generate();
- PointF facePos = detectFace(testBmp);
+ PointF facePos = null;
+ try {
+ facePos = detectFace(testBmp);
+ } catch (OutOfMemoryError e) {
+ L.logRemoteErrorIfProd(e);
+ }
int defaultColor =
ContextCompat.getColor(WikipediaApp.getInstance(), R.color.dark_gray);
listener.get().onImageLoaded(destBitmap.getHeight(), facePos,
extractMainColor(colorPalette, defaultColor));
--
To view, visit https://gerrit.wikimedia.org/r/336848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33c46374243527b6464ea5b56b4d6625d2eaf85c
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
