Martineznovo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/50438


Change subject: Don't break gerrit changeset links on linebreak
......................................................................

Don't break gerrit changeset links on linebreak

Using \s instead of space on Regexp of gerrit changeset RegExp to match
on newline, because "gerrit change <number>" is a long string with many
probabilities of getting auto word-wrapped on bugzilla.

Other Regexp may benefit from this like wikilinks (see bug 39237) but I'm
not sure it would cause problems if there's a opening and closing link
intentionally in several lines.

Change-Id: I43aadb0931addd0f12b678160bcc0bf282a4bd44
---
M bugzilla-4.2/extensions/Wikimedia/Extension.pm
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/modifications 
refs/changes/38/50438/1

diff --git a/bugzilla-4.2/extensions/Wikimedia/Extension.pm 
b/bugzilla-4.2/extensions/Wikimedia/Extension.pm
index 9ca5125..a93e161 100644
--- a/bugzilla-4.2/extensions/Wikimedia/Extension.pm
+++ b/bugzilla-4.2/extensions/Wikimedia/Extension.pm
@@ -52,7 +52,7 @@
 # Testcase: Gerrit 2.5
 # seen in: Summary of https://bugzilla.wikimedia.org/show_bug.cgi?id=41321
        my $replacerGerritChangeset = {
-               match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d{2,})}i,
+               match => qr{\bgerrit(\schange(set)?)?\s?\#?(\d{2,})}i,
                replace => \&_createGerritChangesetLink
        };
 # Testcase: 
https://gerrit.wikimedia.org/r/#q,I0d6c654a7354ba77e65e338423952a6a78c1150f,n,z

-- 
To view, visit https://gerrit.wikimedia.org/r/50438
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43aadb0931addd0f12b678160bcc0bf282a4bd44
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bugzilla/modifications
Gerrit-Branch: master
Gerrit-Owner: Martineznovo <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to