Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337790 )
Change subject: Fix various incomplete/out of sync PHPDoc blocks in client/repo ...................................................................... Fix various incomplete/out of sync PHPDoc blocks in client/repo Change-Id: I6c03c67595fb0ddf4595224a55f7f33216b0b278 --- M client/includes/Specials/SpecialPagesWithBadges.php M client/includes/WikibaseClient.php M repo/includes/Api/SearchEntities.php M repo/includes/ChangeOp/NullChangeOp.php M repo/includes/Hooks/LinkBeginHookHandler.php M repo/includes/Specials/HTMLForm/HTMLItemReferenceField.php M repo/includes/Store/Sql/PropertyInfoTableBuilder.php M repo/includes/Store/Sql/SqlStore.php M repo/includes/WikibaseRepo.php 9 files changed, 27 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/90/337790/1 diff --git a/client/includes/Specials/SpecialPagesWithBadges.php b/client/includes/Specials/SpecialPagesWithBadges.php index b6722d6..beecd8e 100644 --- a/client/includes/Specials/SpecialPagesWithBadges.php +++ b/client/includes/Specials/SpecialPagesWithBadges.php @@ -43,7 +43,6 @@ /** * @see SpecialPage::__construct * - * @param string $name * @param LanguageFallbackLabelDescriptionLookupFactory $labelDescriptionLookupFactory * @param string[] $badgeIds * @param string $siteId @@ -53,12 +52,11 @@ array $badgeIds, $siteId ) { + parent::__construct( 'PagesWithBadges' ); + $this->labelDescriptionLookupFactory = $labelDescriptionLookupFactory; $this->badgeIds = $badgeIds; $this->siteId = $siteId; - - parent::__construct( 'PagesWithBadges' ); - } /** diff --git a/client/includes/WikibaseClient.php b/client/includes/WikibaseClient.php index 94df27a..9735971 100644 --- a/client/includes/WikibaseClient.php +++ b/client/includes/WikibaseClient.php @@ -626,6 +626,7 @@ } /** + * @throws MWException when called to early * @return Language */ public function getContentLanguage() { @@ -645,6 +646,7 @@ } /** + * @throws MWException when called to early * @return Language */ private function getUserLanguage() { diff --git a/repo/includes/Api/SearchEntities.php b/repo/includes/Api/SearchEntities.php index 33e7634..a676d06 100644 --- a/repo/includes/Api/SearchEntities.php +++ b/repo/includes/Api/SearchEntities.php @@ -45,6 +45,7 @@ /** * @param ApiMain $mainModule * @param string $moduleName + * @param EntitySearchHelper $entitySearchHelper * @param EntityTitleLookup $entityTitleLookup * @param ContentLanguages $termLanguages * @param string[] $entityTypes diff --git a/repo/includes/ChangeOp/NullChangeOp.php b/repo/includes/ChangeOp/NullChangeOp.php index 60fcf58..7d30f60 100644 --- a/repo/includes/ChangeOp/NullChangeOp.php +++ b/repo/includes/ChangeOp/NullChangeOp.php @@ -13,14 +13,21 @@ class NullChangeOp implements ChangeOp { /** - * @see ChangeOp::validate() + * @see ChangeOp::validate + * + * @param EntityDocument $entity Unused + * + * @return Result Always valid */ public function validate( EntityDocument $entity ) { return Result::newSuccess(); } /** - * @see ChangeOp::apply() + * @see ChangeOp::apply + * + * @param EntityDocument $entity Unused + * @param Summary|null $summary Unused */ public function apply( EntityDocument $entity, Summary $summary = null ) { // no op diff --git a/repo/includes/Hooks/LinkBeginHookHandler.php b/repo/includes/Hooks/LinkBeginHookHandler.php index d97f53a..e0934fa 100644 --- a/repo/includes/Hooks/LinkBeginHookHandler.php +++ b/repo/includes/Hooks/LinkBeginHookHandler.php @@ -118,6 +118,7 @@ * @param EntityNamespaceLookup $entityNamespaceLookup * @param LanguageFallbackChain $languageFallback * @param Language $pageLanguage + * @param LinkRenderer $linkRenderer * * @todo: Would be nicer to take a LabelDescriptionLookup instead of TermLookup + FallbackChain. */ diff --git a/repo/includes/Specials/HTMLForm/HTMLItemReferenceField.php b/repo/includes/Specials/HTMLForm/HTMLItemReferenceField.php index 556f49e..daa7d9f 100644 --- a/repo/includes/Specials/HTMLForm/HTMLItemReferenceField.php +++ b/repo/includes/Specials/HTMLForm/HTMLItemReferenceField.php @@ -2,6 +2,7 @@ namespace Wikibase\Repo\Specials\HTMLForm; +use Message; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Services\Lookup\EntityLookup; use Wikibase\Repo\WikibaseRepo; @@ -41,7 +42,12 @@ } /** - * @see \HTMLFormField::validate + * @see HTMLFormField::validate + * + * @param string $value + * @param array $alldata + * + * @return bool|string|Message */ public function validate( $value, $alldata ) { $required = isset( $this->mParams['required'] ) && $this->mParams['required'] !== false; diff --git a/repo/includes/Store/Sql/PropertyInfoTableBuilder.php b/repo/includes/Store/Sql/PropertyInfoTableBuilder.php index 4f34cce..82c8997 100644 --- a/repo/includes/Store/Sql/PropertyInfoTableBuilder.php +++ b/repo/includes/Store/Sql/PropertyInfoTableBuilder.php @@ -74,6 +74,7 @@ * @param PropertyInfoTable $propertyInfoTable * @param EntityLookup $entityLookup * @param PropertyInfoBuilder $propertyInfoBuilder + * @param EntityIdComposer $entityIdComposer */ public function __construct( PropertyInfoTable $propertyInfoTable, diff --git a/repo/includes/Store/Sql/SqlStore.php b/repo/includes/Store/Sql/SqlStore.php index ab91f6a..530079a 100644 --- a/repo/includes/Store/Sql/SqlStore.php +++ b/repo/includes/Store/Sql/SqlStore.php @@ -432,7 +432,8 @@ * Creates a strongly connected pair of EntityRevisionLookup services, the first being the * non-caching lookup, the second being the caching lookup. * - * @return [ EntityRevisionLookup, CachingEntityRevisionLookup ] + * @return EntityRevisionLookup[] A two-element array with a "raw", non-caching and a caching + * EntityRevisionLookup. */ private function newEntityRevisionLookup() { // NOTE: Keep cache key in sync with DirectSqlStore::newEntityRevisionLookup in WikibaseClient diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php index ee8ce12..7786178 100644 --- a/repo/includes/WikibaseRepo.php +++ b/repo/includes/WikibaseRepo.php @@ -513,6 +513,7 @@ } /** + * @throws MWException when called to early * @return Language */ private function getContentLanguage() { @@ -532,6 +533,7 @@ } /** + * @throws MWException when called to early * @return Language */ public function getUserLanguage() { -- To view, visit https://gerrit.wikimedia.org/r/337790 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c03c67595fb0ddf4595224a55f7f33216b0b278 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits