Jhernandez has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337822 )
Change subject: Hygiene: Remove unnecessary IIFE in
changeListeners/eventLogging.js
......................................................................
Hygiene: Remove unnecessary IIFE in changeListeners/eventLogging.js
Change-Id: If379092ab5132b47525ba350d6bbb4cee4568a15
---
M src/changeListeners/eventLogging.js
1 file changed, 21 insertions(+), 25 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/22/337822/1
diff --git a/src/changeListeners/eventLogging.js
b/src/changeListeners/eventLogging.js
index a48a85d..38e4540 100644
--- a/src/changeListeners/eventLogging.js
+++ b/src/changeListeners/eventLogging.js
@@ -1,28 +1,24 @@
-( function ( $ ) {
+/**
+ * Creates an instance of the event logging change listener.
+ *
+ * When an event is enqueued to be logged it'll be logged using the schema.
+ * Since it's the responsibility of EventLogging (and the UA) to deliver
+ * logged events, the `EVENT_LOGGED` is immediately dispatched rather than
+ * waiting for some indicator of completion.
+ *
+ * @param {Object} boundActions
+ * @param {mw.eventLog.Schema} schema
+ * @return {ext.popups.ChangeListener}
+ */
+module.exports = function ( boundActions, schema ) {
+ return function ( _, state ) {
+ var eventLogging = state.eventLogging,
+ event = eventLogging.event;
- /**
- * Creates an instance of the event logging change listener.
- *
- * When an event is enqueued to be logged it'll be logged using the
schema.
- * Since it's the responsibility of EventLogging (and the UA) to deliver
- * logged events, the `EVENT_LOGGED` is immediately dispatched rather
than
- * waiting for some indicator of completion.
- *
- * @param {Object} boundActions
- * @param {mw.eventLog.Schema} schema
- * @return {ext.popups.ChangeListener}
- */
- module.exports = function ( boundActions, schema ) {
- return function ( _, state ) {
- var eventLogging = state.eventLogging,
- event = eventLogging.event;
+ if ( event ) {
+ schema.log( $.extend( true, {}, eventLogging.baseData,
event ) );
- if ( event ) {
- schema.log( $.extend( true, {},
eventLogging.baseData, event ) );
-
- boundActions.eventLogged();
- }
- };
+ boundActions.eventLogged();
+ }
};
-
-}( jQuery ) );
+};
--
To view, visit https://gerrit.wikimedia.org/r/337822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If379092ab5132b47525ba350d6bbb4cee4568a15
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
