Jhernandez has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337825 )
Change subject: Hygiene: Remove unnecessary IIFE in changeListeners/render.js
......................................................................
Hygiene: Remove unnecessary IIFE in changeListeners/render.js
Change-Id: Ib313ddd52d59c6422e02d98b67b5b475b35e79b7
---
M src/changeListeners/render.js
1 file changed, 18 insertions(+), 20 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/25/337825/1
diff --git a/src/changeListeners/render.js b/src/changeListeners/render.js
index cf8ecd5..3e92601 100644
--- a/src/changeListeners/render.js
+++ b/src/changeListeners/render.js
@@ -1,23 +1,21 @@
-( function ( mw ) {
+var renderer = require( '../renderer' );
- /**
- * Creates an instance of the render change listener.
- *
- * @param {ext.popups.PreviewBehavior} previewBehavior
- * @return {ext.popups.ChangeListener}
- */
- module.exports = function ( previewBehavior ) {
- var preview;
+/**
+ * Creates an instance of the render change listener.
+ *
+ * @param {ext.popups.PreviewBehavior} previewBehavior
+ * @return {ext.popups.ChangeListener}
+ */
+module.exports = function ( previewBehavior ) {
+ var preview;
- return function ( prevState, state ) {
- if ( state.preview.shouldShow && !preview ) {
- preview = mw.popups.renderer.render(
state.preview.fetchResponse );
- preview.show( state.preview.activeEvent,
previewBehavior );
- } else if ( !state.preview.shouldShow && preview ) {
- preview.hide();
- preview = undefined;
- }
- };
+ return function ( prevState, state ) {
+ if ( state.preview.shouldShow && !preview ) {
+ preview = renderer.render( state.preview.fetchResponse
);
+ preview.show( state.preview.activeEvent,
previewBehavior );
+ } else if ( !state.preview.shouldShow && preview ) {
+ preview.hide();
+ preview = undefined;
+ }
};
-
-}( mediaWiki ) );
+};
--
To view, visit https://gerrit.wikimedia.org/r/337825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib313ddd52d59c6422e02d98b67b5b475b35e79b7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
