Jhernandez has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337831 )
Change subject: Hygiene: Remove unnecessary IIFE in schema.js
......................................................................
Hygiene: Remove unnecessary IIFE in schema.js
Change-Id: Ic152668ff7e4c96fb63934283897a51e81e58dd4
---
M src/schema.js
1 file changed, 20 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/31/337831/1
diff --git a/src/schema.js b/src/schema.js
index 330d01a..af464ff 100644
--- a/src/schema.js
+++ b/src/schema.js
@@ -1,25 +1,23 @@
-( function ( mw, $ ) {
+var mw = window.mediaWiki;
- /**
- * Creates an instance of an EventLogging schema that can be used to log
- * Popups events.
- *
- * @param {mw.Map} config
- * @param {Window} window
- * @return {mw.eventLog.Schema}
- */
- module.exports = function ( config, window ) {
- var samplingRate = config.get( 'wgPopupsSchemaSamplingRate', 0
);
+/**
+ * Creates an instance of an EventLogging schema that can be used to log
+ * Popups events.
+ *
+ * @param {mw.Map} config
+ * @param {Window} window
+ * @return {mw.eventLog.Schema}
+ */
+module.exports = function ( config, window ) {
+ var samplingRate = config.get( 'wgPopupsSchemaSamplingRate', 0 );
- if (
- !window.navigator ||
- !$.isFunction( window.navigator.sendBeacon ) ||
- window.QUnit
- ) {
- samplingRate = 0;
- }
+ if (
+ !window.navigator ||
+ !$.isFunction( window.navigator.sendBeacon ) ||
+ window.QUnit
+ ) {
+ samplingRate = 0;
+ }
- return new mw.eventLog.Schema( 'Popups', samplingRate );
- };
-
-}( mediaWiki, jQuery ) );
+ return new mw.eventLog.Schema( 'Popups', samplingRate );
+};
--
To view, visit https://gerrit.wikimedia.org/r/337831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic152668ff7e4c96fb63934283897a51e81e58dd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
