Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/338070 )

Change subject: Make edit form visually distinct from preview content 
regardless of user settings
......................................................................

Make edit form visually distinct from preview content
regardless of user settings

User may or may not have an edit toolbar; top border should
render regardless.
User may have preview above or below; form should still be
visually distinct if preview is above, so entire thing is
now wrapped in a coloured box like the editoptions.

I don't like this. But there's no meaningful boundary
between the preview and the editform when the preview is
before the editform otherwise. And this is the default
setting.

Change-Id: I8a3f202964964901e9f8b49200beac2920930cd7
---
M modules/ext.CollaborationKit.edit.styles.less
1 file changed, 29 insertions(+), 29 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/70/338070/1

diff --git a/modules/ext.CollaborationKit.edit.styles.less 
b/modules/ext.CollaborationKit.edit.styles.less
index d4660e9..5b7e77c 100644
--- a/modules/ext.CollaborationKit.edit.styles.less
+++ b/modules/ext.CollaborationKit.edit.styles.less
@@ -1,6 +1,6 @@
 @import "ext.CollaborationKit.mixins.less";
 
-.ck-customeditor-toolbars( @default );
+.ck-customeditor-borders( @default );
 
 .mw-collabkit-modifiededitform {
        .oo-ui-fieldLayout.oo-ui-labelElement.oo-ui-fieldLayout-align-top > 
.oo-ui-fieldLayout-body > .oo-ui-fieldLayout-header,
@@ -24,14 +24,14 @@
        }
 }
 
-.ck-customeditor-toolbars( @color ) {
+.ck-customeditor-borders( @color ) {
        .mw-collabkit-modifiededitform {
-               padding-bottom: .75em;
+               padding: 1.5em 1em;
+               border-left: solid 1px fadeout( @color, 85% );
+               border-right: solid 1px fadeout( @color, 85% );
+               border-top: solid 3px @color;
                border-bottom: solid 4px @color;
-       }
-       #toolbar {
-               margin-bottom: .75em;
-               border-bottom: solid 3px @color;
+               background-color: fadeout( @color, 95% );
        }
 }
 
@@ -52,68 +52,68 @@
 }
 
 .mw-ck-theme-darkred {
-       .ck-customeditor-toolbars( @darkred );
+       .ck-customeditor-borders( @darkred );
 }
 .mw-ck-theme-red {
-       .ck-customeditor-toolbars( @red );
+       .ck-customeditor-borders( @red );
 }
 .mw-ck-theme-darkgrey {
-       .ck-customeditor-toolbars( @darkgrey );
+       .ck-customeditor-borders( @darkgrey );
 }
 .mw-ck-theme-lightgrey {
-       .ck-customeditor-toolbars( @lightgrey );
+       .ck-customeditor-borders( @lightgrey );
 }
 .mw-ck-theme-skyblue {
-       .ck-customeditor-toolbars( @skyblue );
+       .ck-customeditor-borders( @skyblue );
 }
 .mw-ck-theme-blue {
-       .ck-customeditor-toolbars( @blue );
+       .ck-customeditor-borders( @blue );
 }
 .mw-ck-theme-bluegrey {
-       .ck-customeditor-toolbars( @bluegrey );
+       .ck-customeditor-borders( @bluegrey );
 }
 .mw-ck-theme-navyblue {
-       .ck-customeditor-toolbars( @navyblue );
+       .ck-customeditor-borders( @navyblue );
 }
 .mw-ck-theme-darkblue {
-       .ck-customeditor-toolbars( @darkblue );
+       .ck-customeditor-borders( @darkblue );
 }
 .mw-ck-theme-aquamarine {
-       .ck-customeditor-toolbars( @aquamarine );
+       .ck-customeditor-borders( @aquamarine );
 }
 .mw-ck-theme-violet {
-       .ck-customeditor-toolbars( @violet );
+       .ck-customeditor-borders( @violet );
 }
 .mw-ck-theme-purple {
-       .ck-customeditor-toolbars( @purple );
+       .ck-customeditor-borders( @purple );
 }
 .mw-ck-theme-mauve {
-       .ck-customeditor-toolbars( @mauve );
+       .ck-customeditor-borders( @mauve );
 }
 .mw-ck-theme-lightmauve {
-       .ck-customeditor-toolbars( @lightmauve );
+       .ck-customeditor-borders( @lightmauve );
 }
 .mw-ck-theme-salmon {
-       .ck-customeditor-toolbars( @salmon );
+       .ck-customeditor-borders( @salmon );
 }
 .mw-ck-theme-orange {
-       .ck-customeditor-toolbars( @orange );
+       .ck-customeditor-borders( @orange );
 }
 .mw-ck-theme-yellow {
-       .ck-customeditor-toolbars( @yellow );
+       .ck-customeditor-borders( @yellow );
 }
 .mw-ck-theme-gold {
-       .ck-customeditor-toolbars( @gold );
+       .ck-customeditor-borders( @gold );
 }
 .mw-ck-theme-pastelyellow {
-       .ck-customeditor-toolbars( @pastelyellow );
+       .ck-customeditor-borders( @pastelyellow );
 }
 .mw-ck-theme-forestgreen {
-       .ck-customeditor-toolbars( @forestgreen );
+       .ck-customeditor-borders( @forestgreen );
 }
 .mw-ck-theme-brightgreen {
-       .ck-customeditor-toolbars( @brightgreen );
+       .ck-customeditor-borders( @brightgreen );
 }
 .mw-ck-theme-khaki {
-       .ck-customeditor-toolbars( @khaki );
+       .ck-customeditor-borders( @khaki );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/338070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a3f202964964901e9f8b49200beac2920930cd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Isarra <zhoris...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to