ItSpiderman has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338126 )
Change subject: Fix for inserting categories with '&' in name
......................................................................
Fix for inserting categories with '&' in name
When category name contains '&', tag is created like
[[Category:D&S|Category:D&S]] which causes several problems, also with
InsertCategory dialog.
As far as i know there is no function that will decode & to &, so i
tried to be as specific as possible, targeting this specific case
ERM: #4904
Needs cherry-picking to REL1_27 and master
Change-Id: I9575713c538c9330f1160d21c1cd1945fee4047f
---
M VisualEditor/resources/tiny_mce_plugins/bswikicode/plugin.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/26/338126/1
diff --git a/VisualEditor/resources/tiny_mce_plugins/bswikicode/plugin.js
b/VisualEditor/resources/tiny_mce_plugins/bswikicode/plugin.js
index 3434a24..47bc292 100644
--- a/VisualEditor/resources/tiny_mce_plugins/bswikicode/plugin.js
+++ b/VisualEditor/resources/tiny_mce_plugins/bswikicode/plugin.js
@@ -683,7 +683,8 @@
}
if (type === "internal_link") {
- if (target === label ) { //TinyMCE3:
tinymce.activeEditor.dom.decode(label)
+ var decodedTarget =
target.replace(/&/g, '&');
+ if (target === label || decodedTarget
=== label) { //TinyMCE3: tinymce.activeEditor.dom.decode(label)
linkwiki = "[[" + target + "]]";
} else {
linkwiki = "[[" + target + "|"
+ label + "]]";
--
To view, visit https://gerrit.wikimedia.org/r/338126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9575713c538c9330f1160d21c1cd1945fee4047f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: ItSpiderman <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
