Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/338137 )

Change subject: Move Rake and RuboCop dependency from repositories to 
mediawiki/selenium
......................................................................

Move Rake and RuboCop dependency from repositories to mediawiki/selenium

Both gems are under development dependencies, but all repositories need
those gems, and of course have them in Gemfiles. It makes more sense to
move the gems to runtime dependency in the gem, so the repositories do
not have to have them in the Gemfile.

Bug: T158326
Change-Id: I5b7e7cb08982599d20048c57d8938e5ed80386e7
---
M mediawiki_selenium.gemspec
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/37/338137/1

diff --git a/mediawiki_selenium.gemspec b/mediawiki_selenium.gemspec
index ee2594a..b6ee035 100644
--- a/mediawiki_selenium.gemspec
+++ b/mediawiki_selenium.gemspec
@@ -33,16 +33,16 @@
   spec.add_runtime_dependency 'mediawiki_api', '~> 0.7', '>= 0.7.0'
   spec.add_runtime_dependency 'page-object', '~> 2.0'
   spec.add_runtime_dependency 'selenium-webdriver', '~> 3.1'
+  spec.add_runtime_dependency 'rake', '~> 10.5'
   spec.add_runtime_dependency 'rest-client', '~> 1.6', '>= 1.6.7'
   spec.add_runtime_dependency 'rspec-core', '~> 2.14', '>= 2.14.4'
   spec.add_runtime_dependency 'rspec-expectations', '~> 2.14', '>= 2.14.4'
+  spec.add_runtime_dependency 'rubocop', '~> 0.46.0'
   spec.add_runtime_dependency 'syntax', '~> 1.2', '>= 1.2.0'
   spec.add_runtime_dependency 'thor', '~> 0.19', '>= 0.19.1'
 
-  spec.add_development_dependency 'rake', '~> 10.5'
   spec.add_development_dependency 'bundler', '~> 1.6', '>= 1.6.3'
   spec.add_development_dependency 'yard', '~> 0.8', '>= 0.8.7.4'
   spec.add_development_dependency 'redcarpet', '~> 3.2', '>= 3.2.0'
-  spec.add_development_dependency 'rubocop', '~> 0.46.0'
   spec.add_development_dependency 'rspec-mocks', '~> 2.14', '>= 2.14.4'
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/338137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b7e7cb08982599d20048c57d8938e5ed80386e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to