Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/332981 )
Change subject: Gemfile: add xmlrpc for ruby 2.4 ...................................................................... Gemfile: add xmlrpc for ruby 2.4 xmlrpc Gem is no more bundled with ruby 2.4. It would fail to install on previous ruby version though which have xmlrpc bundled in. Thus add a conditional to only included 'xmlrpc' for ruby 2.4+ Change-Id: I37c51275acda435518a5b39902d64384e5e9a84c --- M Gemfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Zfilipin: Looks good to me, but someone else must approve Jcrespo: Verified; Looks good to me, approved diff --git a/Gemfile b/Gemfile index 2c72513..0d90683 100644 --- a/Gemfile +++ b/Gemfile @@ -1,6 +1,7 @@ source 'https://rubygems.org' gem 'puppet', '~> 3.7.0' +gem 'xmlrpc' if RUBY_VERSION >= '2.4.0' gem 'puppet-strings', '~> 1.0.0' gem 'rspec-puppet', '~> 2.3.2' gem 'puppetlabs_spec_helper', '< 2.0.0' -- To view, visit https://gerrit.wikimedia.org/r/332981 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37c51275acda435518a5b39902d64384e5e9a84c Gerrit-PatchSet: 5 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Alexandros Kosiaris <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Jcrespo <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
