jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338099 )
Change subject: demo: Use windowAction to open diff dialog
......................................................................
demo: Use windowAction to open diff dialog
Change-Id: I0adaf9a373f525552864aabfa4a929169fa6856e
---
M demos/ve/ve.demo.SurfaceContainer.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/demos/ve/ve.demo.SurfaceContainer.js
b/demos/ve/ve.demo.SurfaceContainer.js
index 73c471a..0eb0486 100644
--- a/demos/ve/ve.demo.SurfaceContainer.js
+++ b/demos/ve/ve.demo.SurfaceContainer.js
@@ -75,7 +75,8 @@
removeButton.on( 'click', this.destroy.bind( this ) );
saveButton.on( 'click', this.save.bind( this ) );
diffButton.on( 'click', function () {
- container.surface.dialogs.openWindow( 'diff', {
+ var windowAction = ve.ui.actionFactory.create( 'window',
container.surface );
+ windowAction.open( 'diff', {
oldDoc: container.oldDoc,
newDoc: container.surface.model.documentModel
} );
--
To view, visit https://gerrit.wikimedia.org/r/338099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0adaf9a373f525552864aabfa4a929169fa6856e
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
