jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338295 )
Change subject: RCFilters UI: Cancel 'editItem' on CapsuleMultiselectWidget
......................................................................
RCFilters UI: Cancel 'editItem' on CapsuleMultiselectWidget
This method assumes you want to edit the item manually, and so
it calls this.$input.val() on a nonexisting input (because there
is no input if a popup exists.)
Bug: T158368
Change-Id: I7bbce89e5280f97d3e85619d9a8fe23fa5e5e47c
---
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
index 9bb1a98..7f8d79d 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
@@ -247,4 +247,9 @@
} );
};
+ /**
+ * Override 'editItem' since it tries to use $input which does
+ * not exist when a popup is available.
+ */
+ mw.rcfilters.ui.FilterCapsuleMultiselectWidget.prototype.editItem =
function () {};
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/338295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bbce89e5280f97d3e85619d9a8fe23fa5e5e47c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
