jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/336912 )
Change subject: Map attributions should be visible when sidebar is open
......................................................................
Map attributions should be visible when sidebar is open
Bug: T152978
Change-Id: Ic9ea2dcee9d60b8eed9e63177e892fc19433e85d
---
M modules/dialog/dialog.js
M styles/dialog.less
2 files changed, 15 insertions(+), 1 deletion(-)
Approvals:
Yurik: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/dialog/dialog.js b/modules/dialog/dialog.js
index 58db1fa..89ff03d 100644
--- a/modules/dialog/dialog.js
+++ b/modules/dialog/dialog.js
@@ -104,6 +104,8 @@
return;
}
+ dialog.$body.toggleClass(
'mw-kartographer-mapDialog-sidebar-opened', open );
+
mw.track( 'mediawiki.kartographer', {
action: open ? 'sidebar-show' : 'sidebar-hide',
isFullScreen: true,
diff --git a/styles/dialog.less b/styles/dialog.less
index 16734dc..70f57bf 100644
--- a/styles/dialog.less
+++ b/styles/dialog.less
@@ -1,5 +1,11 @@
@import '../lib/wmui-base.less';
+/*
+ Anyone who changes the width of the sidebar should
+ update Kartographer.Dialog.DialogClass `SIDEBAR_WIDTH` accordingly
+*/
+@sidebarWidth: 320px;
+
/* Dialog footer */
.mw-kartographer-mapDialog-foot {
/*
@@ -37,7 +43,7 @@
Anyone who changes the width of the sidebar should
update Kartographer.Dialog.DialogClass `SIDEBAR_WIDTH`
accordingly
*/
- width: 321px; /* 320+1 so border is hidden on common 320px wide mobile
devices */
+ width: @sidebarWidth + 1px; /* 320+1 so border is hidden on common
320px wide mobile devices */
box-sizing: border-box;
background-color: #fff;
padding: 3em 2em 1em;
@@ -150,3 +156,9 @@
background-size: 32px;
background-repeat: no-repeat;
}
+
+.mw-kartographer-mapDialog-sidebar-opened {
+ .leaflet-right.leaflet-bottom {
+ right: @sidebarWidth;
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/336912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9ea2dcee9d60b8eed9e63177e892fc19433e85d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
