jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/338154 )

Change subject: Make clicking on library licenses not crash.
......................................................................


Make clicking on library licenses not crash.

Bug: T158263
Change-Id: I2b745ac6f75aa1a364d772a8785e527062c9bccd
---
M app/src/main/AndroidManifest.xml
M app/src/main/res/values/credits.xml
2 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 3caf620..0674bbe 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -149,7 +149,7 @@
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
                 <category android:name="android.intent.category.DEFAULT" />
-                <data android:pathPrefix="/android_asset/licenses/" 
android:scheme="file" />
+                <data android:pathPrefix="/android_asset/licenses/" 
android:scheme="asset" />
             </intent-filter>
         </activity>
         <activity
diff --git a/app/src/main/res/values/credits.xml 
b/app/src/main/res/values/credits.xml
index cb397fa..5b29391 100644
--- a/app/src/main/res/values/credits.xml
+++ b/app/src/main/res/values/credits.xml
@@ -3,54 +3,54 @@
     <string name="contributors_list">Adam Baso, Amir E. Aharoni, Anirudh S, 
Bernd Sitzmann, Brion Vibber, Dan Garry, Dmitry Brant, Elena Tonkovidova, Kaity 
Hammerstein, Kenan Wang, Maryana Pinchuk, Matanya Moses, Max Semenik, Michael 
Holloway, Moiz Syed, Monte Hurd, Mun May Tee, Nicole Borrelli, Niklas 
Laxström, Rummana Yasmeen, Stephen Niedzielski, Thomas PT, Tomasz Finc, Vibha 
Bamba, Yuvi Panda</string>
     <string name="libraries_list"><a 
href="https://jakewharton.github.io/butterknife/";>ButterKnife</a>
         <!-- 
https://raw.githubusercontent.com/JakeWharton/butterknife/master/LICENSE.txt -->
-        (<a href="file:///android_asset/licenses/ButterKnife">license</a>),
+        (<a href="asset:///android_asset/licenses/ButterKnife">license</a>),
 
         <a href="https://commons.apache.org/proper/commons-lang/";>Commons 
Lang</a>
         <!-- https://www.apache.org/licenses/ -->
-        (<a href="file:///android_asset/licenses/CommonsLang3">license</a>),
+        (<a href="asset:///android_asset/licenses/CommonsLang3">license</a>),
 
         <a href="https://github.com/JakeWharton/DiskLruCache";>DiskLruCache</a>
         <!-- 
https://raw.githubusercontent.com/JakeWharton/DiskLruCache/master/LICENSE.txt 
-->
-        (<a href="file:///android_asset/licenses/DiskLruCache">license</a>),
+        (<a href="asset:///android_asset/licenses/DiskLruCache">license</a>),
 
         <a href="http://frescolib.org/";>Fresco</a>
         <!-- https://raw.githubusercontent.com/facebook/fresco/master/LICENSE 
-->
-        (<a href="file:///android_asset/licenses/Fresco">license</a>),
+        (<a href="asset:///android_asset/licenses/Fresco">license</a>),
 
         <a href="https://hockeyapp.net/";>HockeySDK-Android</a>
         <!-- 
https://raw.githubusercontent.com/bitstadium/HockeySDK-Android/develop/LICENSE 
-->
-        (<a 
href="file:///android_asset/licenses/HockeySDK-Android">license</a>),
+        (<a 
href="asset:///android_asset/licenses/HockeySDK-Android">license</a>),
 
         <a href="https://github.com/kevinsawicki/http-request";>Http-Request</a>
         <!-- 
https://raw.githubusercontent.com/kevinsawicki/http-request/master/LICENSE.md 
-->
-        (<a href="file:///android_asset/licenses/Http-Request">license</a>),
+        (<a href="asset:///android_asset/licenses/Http-Request">license</a>),
 
         <a href="https://www.mapbox.com/android-sdk/";>Mapbox Android SDK</a>
         <!-- 
https://raw.githubusercontent.com/mapbox/mapbox-gl-native/master/LICENSE.md-->
-        (<a href="file:///android_asset/licenses/Mapbox">license</a>),
+        (<a href="asset:///android_asset/licenses/Mapbox">license</a>),
 
         <a href="https://square.github.io/okhttp/";>OkHttp</a>
         <!-- 
https://raw.githubusercontent.com/square/okhttp/master/LICENSE.txt -->
-        (<a href="file:///android_asset/licenses/OkHttp">license</a>),
+        (<a href="asset:///android_asset/licenses/OkHttp">license</a>),
 
         <a href="https://github.com/ryanjohn1/onboarding/";>Onboarding</a>
         <!-- https://github.com/ryanjohn1/onboarding/#license -->
-        (<a href="file:///android_asset/licenses/Onboarding">license</a>),
+        (<a href="asset:///android_asset/licenses/Onboarding">license</a>),
 
         <a href="https://square.github.io/otto/";>Otto</a>
         <!-- https://raw.githubusercontent.com/square/otto/master/LICENSE.txt 
-->
-        (<a href="file:///android_asset/licenses/Otto">license</a>),
+        (<a href="asset:///android_asset/licenses/Otto">license</a>),
 
         <a 
href="https://github.com/romandanylyk/PageIndicatorView";>PageIndicatorView</a>
         <!-- https://github.com/romandanylyk/PageIndicatorView#license -->
-        (<a 
href="file:///android_asset/licenses/PageIndicatorView">license</a>),
+        (<a 
href="asset:///android_asset/licenses/PageIndicatorView">license</a>),
 
         <a href="https://square.github.io/retrofit/";>Retrofit</a>
         <!-- 
https://raw.githubusercontent.com/square/retrofit/master/LICENSE.txt -->
-        (<a href="file:///android_asset/licenses/Retrofit">license</a>),
+        (<a href="asset:///android_asset/licenses/Retrofit">license</a>),
 
         <a 
href="https://github.com/ragunathjawahar/android-saripaar";>Saripaar</a>
         <!-- https://github.com/ragunathjawahar/android-saripaar#license -->
-        (<a href="file:///android_asset/licenses/Saripaar">license</a>)
+        (<a href="asset:///android_asset/licenses/Saripaar">license</a>)
     </string>
 </resources>

-- 
To view, visit https://gerrit.wikimedia.org/r/338154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b745ac6f75aa1a364d772a8785e527062c9bccd
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to