jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/336836 )
Change subject: Hygiene: require source files to end with a newline
......................................................................
Hygiene: require source files to end with a newline
Change-Id: I22bc83f343624d955f65d737ae8632f6b1e92dbf
---
M app/src/main/java/org/wikipedia/activity/BaseActivity.java
M app/src/main/java/org/wikipedia/activity/SingleFragmentActivity.java
M app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
M
app/src/main/java/org/wikipedia/descriptions/DescriptionEditTutorialActivity.java
M gradle/src/checkstyle.xml
5 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/activity/BaseActivity.java
b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
index 8d4d12d..6e0ee78 100644
--- a/app/src/main/java/org/wikipedia/activity/BaseActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
@@ -71,4 +71,4 @@
}
}
}
-}
\ No newline at end of file
+}
diff --git
a/app/src/main/java/org/wikipedia/activity/SingleFragmentActivity.java
b/app/src/main/java/org/wikipedia/activity/SingleFragmentActivity.java
index 83873d2..447c607 100644
--- a/app/src/main/java/org/wikipedia/activity/SingleFragmentActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/SingleFragmentActivity.java
@@ -51,4 +51,4 @@
return getFragment() != null;
}
-}
\ No newline at end of file
+}
diff --git
a/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
b/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
index a468bef..2d00e97 100644
--- a/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
@@ -123,4 +123,4 @@
recreate();
}
}
-}
\ No newline at end of file
+}
diff --git
a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditTutorialActivity.java
b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditTutorialActivity.java
index 6598b78..ebc31b6 100644
---
a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditTutorialActivity.java
+++
b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditTutorialActivity.java
@@ -46,4 +46,4 @@
setRequestedOrientation(orientation);
}
-}
\ No newline at end of file
+}
diff --git a/gradle/src/checkstyle.xml b/gradle/src/checkstyle.xml
index bb918b2..6d1918a 100644
--- a/gradle/src/checkstyle.xml
+++ b/gradle/src/checkstyle.xml
@@ -38,6 +38,8 @@
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
<module name="FileTabCharacter"/>
+ <module name="NewlineAtEndOfFile"/>
+
<!-- Miscellaneous other checks. -->
<!-- See http://checkstyle.sf.net/config_misc.html -->
<module name="RegexpSingleline">
--
To view, visit https://gerrit.wikimedia.org/r/336836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22bc83f343624d955f65d737ae8632f6b1e92dbf
Gerrit-PatchSet: 5
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
