jenkins-bot has submitted this change and it was merged.
Change subject: (bug 29127) Fix placement of sign unnecessary message
......................................................................
(bug 29127) Fix placement of sign unnecessary message
Change-Id: Ib9e3bbbad5123a3c48d24496f1ed47d58cf1fb4b
---
M lqt.js
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Martineznovo: Looks good to me, but someone else must approve
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lqt.js b/lqt.js
index 82b6376..cf8cf81 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1146,11 +1146,14 @@
}
// Show the warning
- var msg = mw.msg('lqt-sign-not-necessary');
- var elem = $('<div id="lqt-sign-warning"
class="error"/>');
- elem.text(msg);
+ var elem = $( '<div>' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) ),
+ $weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
- $(this).before( elem );
+ if ( $weTop.length ) {
+ $weTop.before( elem );
+ } else {
+ $( this ).before( elem );
+ }
} else {
prevWarning.remove();
}
--
To view, visit https://gerrit.wikimedia.org/r/50035
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9e3bbbad5123a3c48d24496f1ed47d58cf1fb4b
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Martineznovo <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
