Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338729 )
Change subject: Do not use protected in WikibaseRepo top level factory
......................................................................
Do not use protected in WikibaseRepo top level factory
There are no subclasses, and we do not want subclasses to use or
override this.
Change-Id: I436c2fb1cd73d244d850d41b26669cb6dad5e4ed
---
M repo/includes/WikibaseRepo.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/29/338729/1
diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php
index a7f36fa..4265f34 100644
--- a/repo/includes/WikibaseRepo.php
+++ b/repo/includes/WikibaseRepo.php
@@ -1002,7 +1002,7 @@
/**
* @return OutputFormatValueFormatterFactory
*/
- protected function newValueFormatterFactory() {
+ private function newValueFormatterFactory() {
return new OutputFormatValueFormatterFactory(
$this->dataTypeDefinitions->getFormatterFactoryCallbacks(
DataTypeDefinitions::PREFIXED_MODE ),
$this->getContentLanguage(),
@@ -1093,7 +1093,7 @@
/**
* @return SummaryFormatter
*/
- protected function newSummaryFormatter() {
+ private function newSummaryFormatter() {
// This needs to use an EntityIdPlainLinkFormatter as we want
to mangle
// the links created in LinkBeginHookHandler afterwards (the
links must not
// contain a display text: [[Item:Q1]] is fine but
[[Item:Q1|Q1]] isn't).
@@ -1211,7 +1211,7 @@
*
* @return ValueFormatter
*/
- protected function getMessageParameterFormatter() {
+ private function getMessageParameterFormatter() {
$formatterOptions = new FormatterOptions();
$valueFormatterFactory = $this->getValueFormatterFactory();
--
To view, visit https://gerrit.wikimedia.org/r/338729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I436c2fb1cd73d244d850d41b26669cb6dad5e4ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
