Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/338766 )

Change subject: Make generic @placeholder browser-prefix mixin
......................................................................

Make generic @placeholder browser-prefix mixin

Change-Id: Ic5489c0776f819c3430b0436cfeaa72936f57aea
---
M src/styles/common.less
M src/themes/mediawiki/widgets.less
2 files changed, 27 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/66/338766/1

diff --git a/src/styles/common.less b/src/styles/common.less
index 06add49..3ac9592 100644
--- a/src/styles/common.less
+++ b/src/styles/common.less
@@ -111,3 +111,26 @@
                margin-right: @cancelled-spacing;
        }
 }
+
+.oo-ui-placeholder( @rules ) {
+       // Firefox 4-18
+       :-moz-placeholder { // stylelint-disable-line selector-no-vendor-prefix
+               @rules(); // stylelint-disable-line at-rule-no-unknown
+       }
+       // Firefox 19-
+       ::-moz-placeholder { // stylelint-disable-line selector-no-vendor-prefix
+               @rules(); // stylelint-disable-line at-rule-no-unknown
+       }
+       // Internet Explorer 10-11
+       :-ms-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
+               @rules(); // stylelint-disable-line at-rule-no-unknown
+       }
+       // WebKit, Blink, Edge
+       ::-webkit-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
+               @rules(); // stylelint-disable-line at-rule-no-unknown
+       }
+       // W3C Standard Selectors Level 4
+       :placeholder {
+               @rules(); // stylelint-disable-line at-rule-no-unknown
+       }
+}
diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index ee884a9..9775118 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -1737,26 +1737,10 @@
 
 .mw-placeholder () {
        // Normalize placeholder styling, see T139034
-       // Firefox 4-18
-       :-moz-placeholder { // stylelint-disable-line selector-no-vendor-prefix
+       /* stylelint-disable indentation */
+       .oo-ui-placeholder( {
                color: @color-placeholder;
                opacity: 1;
-       }
-       // Firefox 19-
-       ::-moz-placeholder { // stylelint-disable-line selector-no-vendor-prefix
-               color: @color-placeholder;
-               opacity: 1;
-       }
-       // Internet Explorer 10-11
-       :-ms-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
-               color: @color-placeholder;
-       }
-       // WebKit, Blink, Edge
-       ::-webkit-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
-               color: @color-placeholder;
-       }
-       // W3C Standard Selectors Level 4
-       :placeholder-shown {
-               color: @color-placeholder;
-       }
+       } );
+       /* stylelint-enable indentation */
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/338766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5489c0776f819c3430b0436cfeaa72936f57aea
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to