jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338773 )
Change subject: Use new placeholder mixin
......................................................................
Use new placeholder mixin
Also fix site search to use use the same shade of grey
as is used in OOUI and mw-ui.
Depends-On: I96686bb53cee1a833db8f4d0b691d5e4a1b82885
Change-Id: Ib6437b13760e8c13d06927cb45ef674a5f301e35
---
M components/search.less
M skin.json
2 files changed, 8 insertions(+), 18 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/components/search.less b/components/search.less
index 81297d0..50bfe13 100644
--- a/components/search.less
+++ b/components/search.less
@@ -1,4 +1,5 @@
@import 'mediawiki.mixins';
+@import 'mediawiki.ui/variables';
/* Search */
#p-search {
@@ -56,23 +57,12 @@
outline: 0;
}
- // These rules MAY NOT be merged because of how CSS requires
browsers
- // to parse unrecognized selectors!
- // Note these rules ensure that placeholder text can be
distinguished from
- // standard text. In browsers which make this distinction clear
these rules
- // are not necessary.
- // For inputs that use jquery.placeholder.js e.g. IE9-
- &.placeholder {
- color: #999;
- }
- // Distinguish placeholder text in IE10+
- &:-ms-input-placeholder { // stylelint-disable-line
selector-no-vendor-prefix
- color: #999;
- }
- // Distinguish placeholder text in Firefox 18-
- &:-moz-placeholder { // stylelint-disable-line
selector-no-vendor-prefix
- color: #999;
- }
+ /* stylelint-disable indentation */
+ .mixin-placeholder( {
+ color: @colorGray7;
+ opacity: 1;
+ } );
+ /* stylelint-enable indentation */
// Undo the styles Webkit browsers apply to type=search fields,
// we provide our own
diff --git a/skin.json b/skin.json
index 9f09a93..1802f0a 100644
--- a/skin.json
+++ b/skin.json
@@ -11,7 +11,7 @@
"license-name": "GPL-2.0+",
"type": "skin",
"requires": {
- "MediaWiki": ">= 1.25.0"
+ "MediaWiki": ">= 1.29.0"
},
"ConfigRegistry": {
"vector": "GlobalVarConfig::newInstance"
--
To view, visit https://gerrit.wikimedia.org/r/338773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6437b13760e8c13d06927cb45ef674a5f301e35
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
