Daniel Werner has submitted this change and it was merged.
Change subject: Gives names to all important constructors for improved
debugging experience
......................................................................
Gives names to all important constructors for improved debugging experience
Depends on I78bbf26d8d241574773888a3aa28bc12d34f1b46 in DataValues extension.
Change-Id: Id5859eaf945c7d54aa8858ce9f5fd5aa9725e74e
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
M lib/resources/parsers/EntityIdParser.js
M lib/resources/wikibase.datamodel/wikibase.Claim.js
M lib/resources/wikibase.datamodel/wikibase.EntityId.js
M lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js
M lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js
M lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js
M lib/resources/wikibase.datamodel/wikibase.Reference.js
M lib/resources/wikibase.datamodel/wikibase.Snak.js
M lib/resources/wikibase.datamodel/wikibase.SnakList.js
M lib/resources/wikibase.datamodel/wikibase.Statement.js
M lib/resources/wikibase.js
M lib/resources/wikibase.store/wikibase.EntityStore.js
M lib/resources/wikibase.store/wikibase.RepoApi.js
M lib/resources/wikibase.store/wikibase.RepoApiError.js
17 files changed, 22 insertions(+), 18 deletions(-)
Approvals:
Daniel Werner: Verified; Looks good to me, approved
Henning Snater: Verified
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
index 64e8151..8b98cb4 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
@@ -19,7 +19,7 @@
*
* @param {jQuery.wikibase.snakview} snakView
*/
- var SELF = $.wikibase.snakview.ViewState = function ( snakView ) {
+ var SELF = $.wikibase.snakview.ViewState = function
WbSnakviewViewState( snakView ) {
if( !( snakView instanceof $.wikibase.snakview ) ) {
throw new Error( 'Can not create a snakview ViewState
object without a snakview' );
}
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
index fb6759e..a3863bd 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
@@ -28,7 +28,9 @@
* output, this is where this variation can express its current
state and/or display
* input elements for user interaction.
*/
- var SELF = jQuery.wikibase.snakview.variations.Variation = function(
viewState, $viewPort ) {
+ var SELF = jQuery.wikibase.snakview.variations.Variation =
+ function WbSnakviewVariationsVariation( viewState, $viewPort )
+ {
if( !( viewState instanceof $.wikibase.snakview.ViewState ) ) {
throw new Error( 'No ViewState object was provided to
the snakview variation' );
}
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
index 9d2df15..3464ead 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
@@ -47,8 +47,10 @@
base = SELF.getVariation( base );
}
- var snakType = snakConstructor.TYPE;
- var Variation = wb.utilities.inherit( base, $.extend(
+ var snakType = snakConstructor.TYPE,
+ variatonName = 'WbSnakviewVariations_' +
snakType; // name for constructor
+
+ var Variation = wb.utilities.inherit( variatonName,
base, $.extend(
{ variationBaseClass: 'wb-snakview-variation-'
+ snakType + 'snak' },
variationDefinition,
{ // we don't want to allow to overwrite this
one via the definition
diff --git a/lib/resources/parsers/EntityIdParser.js
b/lib/resources/parsers/EntityIdParser.js
index 5de5a17..e15d73b 100644
--- a/lib/resources/parsers/EntityIdParser.js
+++ b/lib/resources/parsers/EntityIdParser.js
@@ -24,7 +24,7 @@
* @extends vp.ValueParser
* @since 0.4
*/
- wb.EntityIdParser = vp.util.inherit( PARENT, constructor, {
+ wb.EntityIdParser = vp.util.inherit( 'WbEntityIdParser', PARENT,
constructor, {
/**
* @see vp.ValueParser.parse
diff --git a/lib/resources/wikibase.datamodel/wikibase.Claim.js
b/lib/resources/wikibase.datamodel/wikibase.Claim.js
index 7f14098..fd2a2ae 100644
--- a/lib/resources/wikibase.datamodel/wikibase.Claim.js
+++ b/lib/resources/wikibase.datamodel/wikibase.Claim.js
@@ -18,7 +18,7 @@
* @param {String|null} [guid] The Global Unique Identifier of this Claim. Can
be omitted or null
* if this is a new Claim, not yet stored in the database and
associated with some entity.
*/
-wb.Claim = function( mainSnak, qualifiers, guid ) {
+wb.Claim = function WbClaim( mainSnak, qualifiers, guid ) {
this.setMainSnak( mainSnak );
this.setQualifiers( qualifiers || [] );
this._guid = guid || null;
diff --git a/lib/resources/wikibase.datamodel/wikibase.EntityId.js
b/lib/resources/wikibase.datamodel/wikibase.EntityId.js
index 57b08af..6ed4548 100644
--- a/lib/resources/wikibase.datamodel/wikibase.EntityId.js
+++ b/lib/resources/wikibase.datamodel/wikibase.EntityId.js
@@ -31,7 +31,7 @@
this._numericId = numericId;
};
- wb.EntityId = dv.util.inherit( PARENT, constructor, {
+ wb.EntityId = dv.util.inherit( 'WbEntityId', PARENT, constructor, {
/**
* @type String
diff --git a/lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js
b/lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js
index 0a27bf3..fd4d03d 100644
--- a/lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js
+++ b/lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js
@@ -18,7 +18,7 @@
*
* @param {Number} propertyId
*/
-wb.PropertyNoValueSnak = wb.utilities.inherit( PARENT, {} );
+wb.PropertyNoValueSnak = wb.utilities.inherit( 'WbPropertyNoValueSnak',
PARENT, {} );
/**
* @see wb.Snak.TYPE
diff --git a/lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js
b/lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js
index e86d025..ff79cab 100644
--- a/lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js
+++ b/lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js
@@ -19,7 +19,7 @@
* @param {Number} propertyId
* @param {dataValues.Value} value
*/
-wb.PropertySomeValueSnak = wb.utilities.inherit( PARENT, {} );
+wb.PropertySomeValueSnak = wb.utilities.inherit( 'WbPropertySomeValueSnak',
PARENT, {} );
/**
* @see wb.Snak.TYPE
diff --git a/lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js
b/lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js
index ab9947b..8a3cc34 100644
--- a/lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js
+++ b/lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js
@@ -26,7 +26,7 @@
* @param {Number} propertyId
* @param {dv.DataValue} value
*/
-wb.PropertyValueSnak = wb.utilities.inherit( PARENT, constructor, {
+wb.PropertyValueSnak = wb.utilities.inherit( 'WbPropertyValueSnak', PARENT,
constructor, {
/**
* @type dv.DataValue
*/
diff --git a/lib/resources/wikibase.datamodel/wikibase.Reference.js
b/lib/resources/wikibase.datamodel/wikibase.Reference.js
index 6fc34b6..29752f7 100644
--- a/lib/resources/wikibase.datamodel/wikibase.Reference.js
+++ b/lib/resources/wikibase.datamodel/wikibase.Reference.js
@@ -22,7 +22,7 @@
* TODO: get rid of 'hash' parameter and introduce a method to generate
the hash, but make sure
* it will be the same as it would be for a Reference in PHP.
*/
- wb.Reference = function( snaks, hash ) {
+ wb.Reference = function WbReference( snaks, hash ) {
this.setSnaks( snaks );
this._hash = hash;
};
diff --git a/lib/resources/wikibase.datamodel/wikibase.Snak.js
b/lib/resources/wikibase.datamodel/wikibase.Snak.js
index aa3f4bf..020abbe 100644
--- a/lib/resources/wikibase.datamodel/wikibase.Snak.js
+++ b/lib/resources/wikibase.datamodel/wikibase.Snak.js
@@ -16,7 +16,7 @@
*
* @param {String} propertyId
*/
-wb.Snak = function( propertyId ) {
+wb.Snak = function WbSnak( propertyId ) {
// check whether the Snak has a type, doesn't make sense to create an
instance of wb.Snak!
if( !this.constructor.TYPE ) {
throw new Error( 'Can not create abstract Snak of no specific
type' );
diff --git a/lib/resources/wikibase.datamodel/wikibase.SnakList.js
b/lib/resources/wikibase.datamodel/wikibase.SnakList.js
index 7bf10ed..cb66050 100644
--- a/lib/resources/wikibase.datamodel/wikibase.SnakList.js
+++ b/lib/resources/wikibase.datamodel/wikibase.SnakList.js
@@ -18,7 +18,7 @@
*
* @param {wb.Snak[]|wb.Snak|wb.SnakList} [snaks] One or more Snaks in the
list initially.
*/
-wb.SnakList = function( snaks ) {
+wb.SnakList = function WbSnakList( snaks ) {
this._snaks = [];
this.length = 0;
diff --git a/lib/resources/wikibase.datamodel/wikibase.Statement.js
b/lib/resources/wikibase.datamodel/wikibase.Statement.js
index 0c7ff8b..ff8db7d 100644
--- a/lib/resources/wikibase.datamodel/wikibase.Statement.js
+++ b/lib/resources/wikibase.datamodel/wikibase.Statement.js
@@ -28,7 +28,7 @@
* @param {String|null} [guid] The Global Unique Identifier of this Statement.
Can be omitted or null
* if this is a new Statement, not yet stored in the database and
associated with some entity.
*/
-wb.Statement = wb.utilities.inherit( PARENT, constructor, {
+wb.Statement = wb.utilities.inherit( 'WbStatement', PARENT, constructor, {
/**
* @type Array
* @todo determine whether we should rather model a Reference object
for this
diff --git a/lib/resources/wikibase.js b/lib/resources/wikibase.js
index 3753d51..26f91df 100644
--- a/lib/resources/wikibase.js
+++ b/lib/resources/wikibase.js
@@ -39,7 +39,7 @@
* (see TODO/FIXME in wikibase.ui.entityViewInit - handle edit
restrictions)
* (1) {jQuery.Event}
*/
-var wikibase = new ( function( mw, $, undefined ) {
+var wikibase = new ( function Wb( mw, $ ) {
'use strict';
/**
diff --git a/lib/resources/wikibase.store/wikibase.EntityStore.js
b/lib/resources/wikibase.store/wikibase.EntityStore.js
index f9dd5e7..c35fe46 100644
--- a/lib/resources/wikibase.store/wikibase.EntityStore.js
+++ b/lib/resources/wikibase.store/wikibase.EntityStore.js
@@ -18,7 +18,7 @@
* entities. ItemStore, PropertyStore etc... wb.RepoApi could still be
an implementation for
* more than just one of these.
*/
-wb.EntityStore = function() {};
+wb.EntityStore = function WbEntityStore() {};
wb.EntityStore.prototype = {
/**
diff --git a/lib/resources/wikibase.store/wikibase.RepoApi.js
b/lib/resources/wikibase.store/wikibase.RepoApi.js
index 8ba746f..463ff5a 100644
--- a/lib/resources/wikibase.store/wikibase.RepoApi.js
+++ b/lib/resources/wikibase.store/wikibase.RepoApi.js
@@ -27,7 +27,7 @@
* @extends wb.EntityStore
* @since 0.4 (since 0.3 as wb.Api without support for client usage)
*/
-wb.RepoApi = wb.utilities.inherit( PARENT, {
+wb.RepoApi = wb.utilities.inherit( 'WbRepoApi', PARENT, {
/**
* mediaWiki.Api object for internal usage. By having this initialized
in the prototype, we can
diff --git a/lib/resources/wikibase.store/wikibase.RepoApiError.js
b/lib/resources/wikibase.store/wikibase.RepoApiError.js
index 2df3c4d..9779b12 100644
--- a/lib/resources/wikibase.store/wikibase.RepoApiError.js
+++ b/lib/resources/wikibase.store/wikibase.RepoApiError.js
@@ -33,7 +33,7 @@
this.message = this.getMessage();
};
- wb.RepoApiError = wb.utilities.inherit( PARENT, constructor,
+ wb.RepoApiError = wb.utilities.inherit( 'WbRepoApiError', PARENT,
constructor,
{
/**
* Message keys of API related error messages.
--
To view, visit https://gerrit.wikimedia.org/r/50187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5859eaf945c7d54aa8858ce9f5fd5aa9725e74e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
