jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/339155 )
Change subject: Add SPARQL query as hidden table column to allow filtering ...................................................................... Add SPARQL query as hidden table column to allow filtering Bug:T154768 Change-Id: Ib610e9dde3470df85b005a61cc86ef7dd8eee5ec --- M wikibase/queryService/ui/QueryExampleDialog.js 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Smalyshev: Looks good to me, approved jenkins-bot: Verified diff --git a/wikibase/queryService/ui/QueryExampleDialog.js b/wikibase/queryService/ui/QueryExampleDialog.js index 733039f..0d110b5 100644 --- a/wikibase/queryService/ui/QueryExampleDialog.js +++ b/wikibase/queryService/ui/QueryExampleDialog.js @@ -117,7 +117,7 @@ if ( example.category !== category ) { category = example.category; self._$element.find( '.searchable' ).append( $( '<tr>' ).addClass( 'active' ) - .append( $( '<td colspan="3">' ).text( category ) ) ); + .append( $( '<td colspan="4">' ).text( category ) ) ); } self._addExample( example.title, example.query, example.href, example.tags ); } ); @@ -235,7 +235,7 @@ self._track( 'edit' ); } ), - source = $( '<span>' ).addClass( 'glyphicon glyphicon-eye-open' ).popover( + $source = $( '<span>' ).addClass( 'glyphicon glyphicon-eye-open' ).popover( { placement: 'bottom', trigger: 'hover', @@ -244,7 +244,7 @@ content: $( '<pre style="white-space:pre-line; word-break:break-word;"/>' ).text( query ), html: true } ), - preview = $( '<a href="#">' ).addClass( 'glyphicon glyphicon-camera' ).clickover( + $preview = $( '<a href="#">' ).addClass( 'glyphicon glyphicon-camera' ).clickover( { placement: 'left', 'global_close': true, @@ -258,19 +258,19 @@ .click( function() { self._track( 'preview' ); } ); - $( '.exampleTable' ).scroll( function() { - if ( preview.clickover ) { - preview.clickover( 'hide' ).removeAttr( 'data-clickover-open' ); + + $( '.exampleTable' ).scroll( function() { + if ( $preview.clickover ) { + $preview.clickover( 'hide' ).removeAttr( 'data-clickover-open' ); } } ); - tags = $( '<td>' ).text( tags.join( '|' ) ).hide(); - var example = $( '<tr>' ); example.append( $( '<td>' ).append( $link ).append( ' ', $edit ) ); - example.append( $( '<td>' ).append( preview ) ); - example.append( $( '<td>' ).append( source ) ); - example.append( tags ); + example.append( $( '<td>' ).append( $preview ) ); + example.append( $( '<td>' ).append( $source ) ); + example.append( $( '<td>' ).text( tags.join( '|' ) ).hide() ); + example.append( $( '<td>' ).text( query ).hide() ); this._$element.find( '.searchable' ).append( example ); }; -- To view, visit https://gerrit.wikimedia.org/r/339155 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib610e9dde3470df85b005a61cc86ef7dd8eee5ec Gerrit-PatchSet: 1 Gerrit-Project: wikidata/query/gui Gerrit-Branch: master Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de> Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits