Pmiazga has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339799 )
Change subject: Show only search icon inside .header element
......................................................................
Show only search icon inside .header element
Changes:
- moved input.search declaration into .header section
Bug: T159009
Change-Id: Ic9b394394bb07dfad45cfdb1935040f98ef2960c
---
M resources/skins.minerva.base.styles/ui.less
1 file changed, 21 insertions(+), 21 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/99/339799/1
diff --git a/resources/skins.minerva.base.styles/ui.less
b/resources/skins.minerva.base.styles/ui.less
index d3bdf61..41bf0a2 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -52,6 +52,27 @@
// FIXME: Remove when cache clears
width: 100%;
+ /* Search */
+ input.search {
+ // FIXME: input's cannot have child elements so not possible to
use mw-ui-icon-before here
+ // How can we avoid multiple use of magnifying glass icon?
+ .background-image-svg( 'magnifying-glass.svg',
'magnifying-glass.png' );
+ outline: 0;
+ width: 100%;
+ // FIXME: unable to check but the important may not be needed
for Nokia S60;
+ background-color: #fff !important; /* remove fennec default
background also see bug 36490 */
+ // get rid of rounded corners in Safari
+ -webkit-appearance: none;
+
+ // [T139928] Hide all pseudo-elements added to search inputs in
WebKit.
+ &::-webkit-search-decoration,
+ &::-webkit-search-cancel-button,
+ &::-webkit-search-results-button,
+ &::-webkit-search-results-decoration {
+ display: none;
+ }
+ }
+
.search {
@searchIconSize: 20px;
@searchIconGutter: 6px;
@@ -212,27 +233,6 @@
padding: 0.5em 0.1em;
background: none; // so that the icon doesn't overlap
with the placeholder
}
- }
-}
-
-/* Search */
-input.search {
- // FIXME: input's cannot have child elements so not possible to use
mw-ui-icon-before here
- // How can we avoid multiple use of magnifying glass icon?
- .background-image-svg( 'magnifying-glass.svg', 'magnifying-glass.png' );
- outline: 0;
- width: 100%;
- // FIXME: unable to check but the important may not be needed for Nokia
S60;
- background-color: #fff !important; /* remove fennec default background
also see bug 36490 */
- // get rid of rounded corners in Safari
- -webkit-appearance: none;
-
- // [T139928] Hide all pseudo-elements added to search inputs in WebKit.
- &::-webkit-search-decoration,
- &::-webkit-search-cancel-button,
- &::-webkit-search-results-button,
- &::-webkit-search-results-decoration {
- display: none;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/339799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9b394394bb07dfad45cfdb1935040f98ef2960c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
