Framawiki has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/339839 )

Change subject: DON'T MERGE: UI: message for API error when publishing: 
invalidtitle
......................................................................

DON'T MERGE: UI: message for API error when publishing: invalidtitle

Hello, it's my first commit to this extension :)
This commit fix bad error message that is printed when user whant to
publish to a bad page title (code === 'invalidtitle').
I've used the existing mediawiki core message 'title-invalid-characters',
but I did not understand how "register" this message. So in this form
client haven't it and it's printed hard-coded :(
Can you help me ? Thanks !

Bug: T159054
Change-Id: If82b2d625bb9a61f12c302397d82058daa61cbae
---
M modules/publish/ext.cx.publish.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/39/339839/1

diff --git a/modules/publish/ext.cx.publish.js 
b/modules/publish/ext.cx.publish.js
index 47da28d..397b376 100644
--- a/modules/publish/ext.cx.publish.js
+++ b/modules/publish/ext.cx.publish.js
@@ -289,7 +289,9 @@
                } else {
                        // Try providing useful error information. "Unknown" by 
default.
                        error = mw.msg( 'unknown-error' );
-                       if ( details.error && details.error.info ) {
+                       if (code === 'invalidtitle') {
+                               error = mw.message( 'title-invalid-characters', 
this.targetTitle ).text())
+                       } else if ( details.error && details.error.info ) {
                                // 
{"servedby":"mw####","error":{"code":"blocked","info":"You have been blocked 
from editing",
                                // "*":"See ...
                                error = details.error.info;

-- 
To view, visit https://gerrit.wikimedia.org/r/339839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If82b2d625bb9a61f12c302397d82058daa61cbae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Framawiki <framaw...@tools.wmflabs.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to