Harej has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/339813 )
Change subject: Adding hub section main bodies to their own container and
setting padding
......................................................................
Adding hub section main bodies to their own container and setting padding
I think having the buttons become in-line with the H2 headers broke
padding. This fixes that by having everything after the top being
in a container div, with padding-top set to 0.25 em.
Change-Id: Id4fc1f85a23993d1ad1955c655dcef9e25195365
---
M includes/content/CollaborationHubContent.php
M modules/ext.CollaborationKit.hub.styles.less
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Isarra: Looks good to me, approved
diff --git a/includes/content/CollaborationHubContent.php
b/includes/content/CollaborationHubContent.php
index aa135bc..bf3f983 100644
--- a/includes/content/CollaborationHubContent.php
+++ b/includes/content/CollaborationHubContent.php
@@ -594,7 +594,7 @@
$text = $contentOutput->getRawText();
}
- $html .= $text;
+ $html .= Html::rawElement( 'div', [ 'class' =>
'mw-ck-hub-section-main' ], $text );
// register as template for stuff
$output->addTemplate( $spTitle,
$spTitle->getArticleID(), $spRev->getId() );
diff --git a/modules/ext.CollaborationKit.hub.styles.less
b/modules/ext.CollaborationKit.hub.styles.less
index b5bcb8b..468deb6 100644
--- a/modules/ext.CollaborationKit.hub.styles.less
+++ b/modules/ext.CollaborationKit.hub.styles.less
@@ -61,13 +61,17 @@
h2 {
display: inline;
+ padding: 0;
margin: 0;
- padding: 0 0 .25em;
border-bottom-style: none;
border-top-style: none;
border-left-style: none;
border-right-style: none;
}
+
+ .mw-ck-hub-section-main {
+ padding-top: .25em;
+ }
}
.mw-ck-hub-section-buttons {
display: inline;
--
To view, visit https://gerrit.wikimedia.org/r/339813
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4fc1f85a23993d1ad1955c655dcef9e25195365
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>
Gerrit-Reviewer: Harej <jamesmh...@gmail.com>
Gerrit-Reviewer: Isarra <zhoris...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
