Hello Andrew Bogott,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/340064
to review the following change.
Change subject: puppet: Remove requirement on python3-ldap3
......................................................................
puppet: Remove requirement on python3-ldap3
Since c658ac3d3795d3186cce7f43ddd3a3cd0603e3a4,
modules/role/files/labs/puppet-enc.py no longer queries the LDAP
server and thus does not use ldap3 any longer. This change removes
the now obsolete requirement in the manifests.
Change-Id: I25e783fe6b4c59d04e024620bebd179ee8767a71
---
M modules/puppet/manifests/self/config.pp
M modules/role/manifests/puppetmaster/standalone.pp
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/64/340064/1
diff --git a/modules/puppet/manifests/self/config.pp
b/modules/puppet/manifests/self/config.pp
index 84e6f13..2f35c23 100644
--- a/modules/puppet/manifests/self/config.pp
+++ b/modules/puppet/manifests/self/config.pp
@@ -28,7 +28,7 @@
fail('Ldap puppet node definitions are no longer supported. The
$use_enc param must be true.')
}
- require_package('python3-yaml', 'python3-ldap3')
+ require_package('python3-yaml')
include ::ldap::yamlcreds
diff --git a/modules/role/manifests/puppetmaster/standalone.pp
b/modules/role/manifests/puppetmaster/standalone.pp
index 8fd8516..58d1fe4 100644
--- a/modules/role/manifests/puppetmaster/standalone.pp
+++ b/modules/role/manifests/puppetmaster/standalone.pp
@@ -48,7 +48,7 @@
}
# Setup ENC
- require_package('python3-yaml', 'python3-ldap3')
+ require_package('python3-yaml')
include ldap::yamlcreds
--
To view, visit https://gerrit.wikimedia.org/r/340064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25e783fe6b4c59d04e024620bebd179ee8767a71
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
