Prtksxna has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340282 )
Change subject: ComboBoxInputWidget: Use icon instead of indicator for dropdown
button
......................................................................
ComboBoxInputWidget: Use icon instead of indicator for dropdown button
Bug: T159204
Change-Id: I1d4882eb1a2f96845e27d923031fa37fb2205ffb
---
M src/styles/widgets/ComboBoxInputWidget.less
M src/widgets/ComboBoxInputWidget.js
2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/82/340282/1
diff --git a/src/styles/widgets/ComboBoxInputWidget.less
b/src/styles/widgets/ComboBoxInputWidget.less
index a8464ad..b46df26 100644
--- a/src/styles/widgets/ComboBoxInputWidget.less
+++ b/src/styles/widgets/ComboBoxInputWidget.less
@@ -17,12 +17,19 @@
overflow: hidden;
}
- &-dropdownButton {
+ &-dropdownButton.oo-ui-buttonElement-framed.oo-ui-iconElement {
display: table-cell;
> .oo-ui-buttonElement-button {
display: block;
overflow: hidden;
+
+ > .oo-ui-iconElement-icon {
+ min-width: 12px;
+ width: 1.1em;
+ min-height: 12px;
+ left: 1em;
+ }
}
}
diff --git a/src/widgets/ComboBoxInputWidget.js
b/src/widgets/ComboBoxInputWidget.js
index 5462ed8..af90c90 100644
--- a/src/widgets/ComboBoxInputWidget.js
+++ b/src/widgets/ComboBoxInputWidget.js
@@ -73,7 +73,7 @@
this.$overlay = config.$overlay || this.$element;
this.dropdownButton = new OO.ui.ButtonWidget( {
classes: [ 'oo-ui-comboBoxInputWidget-dropdownButton' ],
- indicator: 'down',
+ icon: 'downTriangle',
disabled: this.disabled
} );
this.menu = new OO.ui.FloatingMenuSelectWidget( $.extend(
--
To view, visit https://gerrit.wikimedia.org/r/340282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d4882eb1a2f96845e27d923031fa37fb2205ffb
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
