jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/340423 )

Change subject: Cleanup of CollaborationListContent.php
......................................................................


Cleanup of CollaborationListContent.php

Change-Id: I078470d8eeffb33a5b57cfab8dcbc523fe919c5d
---
M includes/content/CollaborationListContent.php
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Brian Wolff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/content/CollaborationListContent.php 
b/includes/content/CollaborationListContent.php
index ea33144..a3fb1bf 100644
--- a/includes/content/CollaborationListContent.php
+++ b/includes/content/CollaborationListContent.php
@@ -25,7 +25,7 @@
        const HUMAN_DESC_SPLIT = "\n-----------------------\n";
        // Splitter denoting the beginning of a list column
        const HUMAN_COLUMN_SPLIT = "\n---------~-~---------\n";
-       // Splitter denoting the beginning og the list itself within the column
+       // Splitter denoting the beginning of the list itself within the column
        const HUMAN_COLUMN_SPLIT2 = "\n---------------------\n";
 
        /** @var $decoded boolean Have we decoded the data yet */
@@ -108,10 +108,7 @@
 
                // Special handling for DISPLAYMODE
                if ( $name == 'DISPLAYMODE' ) {
-                       if ( $value == 'members' || $value == 'normal' || 
$value == 'error' ) {
-                               return true;
-                       }
-                       return false;
+                       return ( $value == 'members' || $value == 'normal' || 
$value == 'error' );
                }
 
                // Force intrepretation as boolean for certain options

-- 
To view, visit https://gerrit.wikimedia.org/r/340423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I078470d8eeffb33a5b57cfab8dcbc523fe919c5d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to