Harej has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340437 )
Change subject: Removing unimplemented/commented-out code
......................................................................
Removing unimplemented/commented-out code
They will possibly be implemented at a later date but in the meantime
it is not necessary to keep them in the master branch.
Change-Id: Iaacf5ea405119d03146a6712fc7d91b1eea4f9d9
---
D includes/ApiEditCollaborationHub.php
M includes/content/CollaborationHubContentHandler.php
D includes/content/CollaborationHubDiffEngine.php
M includes/content/CollaborationListContentHandler.php
4 files changed, 0 insertions(+), 66 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit
refs/changes/37/340437/1
diff --git a/includes/ApiEditCollaborationHub.php
b/includes/ApiEditCollaborationHub.php
deleted file mode 100644
index 5fddd6d..0000000
--- a/includes/ApiEditCollaborationHub.php
+++ /dev/null
@@ -1,14 +0,0 @@
-<?php
-/**
- * API module to edit a CollaborationHub
- *
- * @ingroup API
- */
-class ApiEditCollaborationHub extends ApiBase {
-
- public function execute() {
- $data = $this->extractRequestParams();
- }
-
- // TODO Implement this
-}
diff --git a/includes/content/CollaborationHubContentHandler.php
b/includes/content/CollaborationHubContentHandler.php
index 29a9181..144ea14 100644
--- a/includes/content/CollaborationHubContentHandler.php
+++ b/includes/content/CollaborationHubContentHandler.php
@@ -91,13 +91,6 @@
}
/**
- * @return string
- */
- /*protected function getDiffEngineClass() {
- return 'CollaborationHubDiffEngine';
- }*/
-
- /**
* @return bool
*/
public function isParserCacheSupported() {
diff --git a/includes/content/CollaborationHubDiffEngine.php
b/includes/content/CollaborationHubDiffEngine.php
deleted file mode 100644
index 2ef7055..0000000
--- a/includes/content/CollaborationHubDiffEngine.php
+++ /dev/null
@@ -1,32 +0,0 @@
-<?php
-
-/**
- * Custom diff engine for CollaborationHubContent. Not yet implemented.
- *
- * @file
- */
-
-class CollaborationHubDiffEngine extends DifferenceEngine {
-
- /**
- * Implement our own diff rendering.
- * @param Content $old Old content
- * @param Content $new New content
- * @throws Exception If old or new content is not an instance of
CollaborationHubContent
- * @return bool|string
- */
- public function generateContentDiffBody( Content $old, Content $new ) {
- if ( !( $old instanceof CollaborationHubContent )
- || !( $new instanceof CollaborationHubContent )
- ) {
- throw new Exception( 'CollaborationKit cannot diff
content types other than CollaborationHubContent' );
- }
-
- $output = '';
-
- // PANIC
- // TODO Implement this
-
- return $output;
- }
-}
diff --git a/includes/content/CollaborationListContentHandler.php
b/includes/content/CollaborationListContentHandler.php
index 9aedc0d..c7ee8fe 100644
--- a/includes/content/CollaborationListContentHandler.php
+++ b/includes/content/CollaborationListContentHandler.php
@@ -120,25 +120,12 @@
}
/**
- * @return string
- */
- /*protected function getDiffEngineClass() {
- return 'CollaborationListDiffEngine';
- }*/
-
- /**
* FIXME is this really true?
* @return bool
*/
public function isParserCacheSupported() {
return true;
}
-
-/**** This disables Special:ChangeContentModel
- public function supportsDirectEditing() {
- return false;
- }
-*/
/**
* @return bool
--
To view, visit https://gerrit.wikimedia.org/r/340437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaacf5ea405119d03146a6712fc7d91b1eea4f9d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
