Mooeypoo has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/341388 )
Change subject: RCFilters UI: Fix scrolling behavior on search/popup
......................................................................
RCFilters UI: Fix scrolling behavior on search/popup
Bug: T158018
Change-Id: I7278f34018721e7631ed3f9307e093bd55ff7d24
---
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/341388/1
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js
index 7da97a1..886dc43 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterWrapperWidget.js
@@ -186,11 +186,12 @@
*/
mw.rcfilters.ui.FilterWrapperWidget.prototype.scrollToTop = function (
$element, marginFromTop ) {
var container =
OO.ui.Element.static.getClosestScrollableContainer( $element[ 0 ], 'y' ),
- pos = OO.ui.Element.static.getRelativePosition(
$element, $( container ) );
+ pos = OO.ui.Element.static.getRelativePosition(
$element, $( container ) ),
+ containerScrollTop = $( container ).is( 'body' ) ? 0 :
$( container ).scrollTop();
// Scroll to item
$( container ).animate( {
- scrollTop: $( container ).scrollTop() + pos.top + (
marginFromTop || 0 )
+ scrollTop: containerScrollTop + pos.top - (
marginFromTop || 0 )
} );
};
}( mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/341388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7278f34018721e7631ed3f9307e093bd55ff7d24
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
