jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/341364 )
Change subject: Do not lazy-load an event logging module
......................................................................
Do not lazy-load an event logging module
Since we're always depending on the event logging module, we can
make it a dependency in extension.json, rather than loading it
lazily.
Bug: T157375
Change-Id: Ia57f390586e123c6010a7daf23a3d851daf079ce
---
M extension.json
M resources/ext.relatedArticles.readMore.bootstrap/index.js
2 files changed, 5 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Phuedx: Looks good to me, approved
diff --git a/extension.json b/extension.json
index 5428e47..e5f8202 100644
--- a/extension.json
+++ b/extension.json
@@ -84,6 +84,7 @@
"mediawiki.Uri",
"mediawiki.viewport",
"ext.relatedArticles.readMore.gateway",
+ "ext.relatedArticles.readMore.eventLogging",
"jquery.throttle-debounce"
],
"targets": [
@@ -93,7 +94,8 @@
},
"ext.relatedArticles.readMore": {
"dependencies": [
- "mediawiki.util"
+ "mediawiki.util",
+ "ext.relatedArticles.readMore.eventLogging"
],
"scripts": [
"resources/ext.relatedArticles.readMore/index.js"
diff --git a/resources/ext.relatedArticles.readMore.bootstrap/index.js
b/resources/ext.relatedArticles.readMore.bootstrap/index.js
index 838c5fd..afe42f1 100644
--- a/resources/ext.relatedArticles.readMore.bootstrap/index.js
+++ b/resources/ext.relatedArticles.readMore.bootstrap/index.js
@@ -60,8 +60,7 @@
// which should never happen given the if
statement.
mw.loader.using( [
'ext.cards',
- 'ext.relatedArticles.readMore',
-
'ext.relatedArticles.readMore.eventLogging'
+ 'ext.relatedArticles.readMore'
] ),
relatedPages.getForCurrentPage( LIMIT )
).done( function ( _, pages ) {
@@ -94,7 +93,5 @@
loadRelatedArticles();
}
- mw.loader.using( 'ext.relatedArticles.readMore.eventLogging' ).done(
function () {
- mw.track( 'ext.relatedArticles.logEnabled', { isEnabled:
shouldShowReadMore } );
- } );
+ mw.track( 'ext.relatedArticles.logEnabled', { isEnabled:
shouldShowReadMore } );
}( jQuery, mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/341364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia57f390586e123c6010a7daf23a3d851daf079ce
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
