jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/341495 )

Change subject: Avoid invalid characters in memcache keys
......................................................................


Avoid invalid characters in memcache keys

Just sha1() the title before it is used in the memcache key.

Bug: T159783
Change-Id: Ieef5c8383f4d6b61158450e1eff6c04a85ed4a27
---
M includes/JCCache.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/JCCache.php b/includes/JCCache.php
index c352a65..fc396ee 100644
--- a/includes/JCCache.php
+++ b/includes/JCCache.php
@@ -34,7 +34,7 @@
                        $conf->cacheKey,
                        ( $flRev === null ? '' : ( $flRev ? 'T' : 'F' ) ),
                        $titleValue->getNamespace(),
-                       $titleValue->getDBkey()
+                       sha1( $titleValue->getDBkey() ),
                ] );
                if ( $conf->isLocal ) {
                        $key = wfMemcKey( $key );

-- 
To view, visit https://gerrit.wikimedia.org/r/341495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieef5c8383f4d6b61158450e1eff6c04a85ed4a27
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to