jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/341366 )
Change subject: renderer: Ensure settings cog visible in IE9-11
......................................................................
renderer: Ensure settings cog visible in IE9-11
Following on from I19e67ae4, IE9-11's treatment of SVG elements that
overflow their containers means that the truncating pseudo-element and
the settings cog is occluded in a portrait-mode preview.
"Pad" the extract horizontally using a margin to force the SVG element
into the correct position.
Bug: T156800
Bug: T139297
Change-Id: I0da6af6d4cbcc69c6465b37714856e59199ae6e4
---
M resources/ext.popups/styles/ext.popups.core.less
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/resources/ext.popups/styles/ext.popups.core.less
b/resources/ext.popups/styles/ext.popups.core.less
index c8a76ef..415d18a 100644
--- a/resources/ext.popups/styles/ext.popups.core.less
+++ b/resources/ext.popups/styles/ext.popups.core.less
@@ -109,8 +109,13 @@
}
.mwe-popups-extract {
- margin: 0;
- padding: 16px;
+
+ // T156800, T139297: "Pad" the extract horizontally using a
margin so the
+ // SVG element is forced not to occlude the truncating
pseudo-element and
+ // the settings cog in IE9-11.
+ padding: 16px 0;
+ margin: 0 16px;
+
display: block;
color: #000;
text-decoration: none;
--
To view, visit https://gerrit.wikimedia.org/r/341366
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0da6af6d4cbcc69c6465b37714856e59199ae6e4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
