jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/342147 )

Change subject: [noop] Move NavigationTiming config to EventLogging section
......................................................................


[noop] Move NavigationTiming config to EventLogging section

Change-Id: Id7f2fcdb3bda8448a499d2aeed62ca5b6f870eae
---
M wmf-config/CommonSettings.php
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dereckson: Looks good to me, approved



diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 20c16e9..ff3d807 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2926,7 +2926,7 @@
        // Temporary hack for 'jsonschema' API module migration
        $wgEventLoggingSchemaIndexUri = $wgEventLoggingSchemaApiUri;
 
-       // Extensions dependent on EventLogging
+       // Depends on EventLogging
        if ( $wmgUseCampaigns ) {
                wfLoadExtension( 'Campaigns' );
        }
@@ -2934,16 +2934,17 @@
        wfLoadExtension( 'WikimediaEvents' );
        $wgWMEStatsdBaseUri = '/beacon/statsv';
        $wgWMETrackGeoFeatures = $wmgWMETrackGeoFeatures;
-}
 
-if ( $wmgUseEventLogging && $wmgUseNavigationTiming ) {
-       wfLoadExtension( 'NavigationTiming' );
-       // Careful! The LOWER the value, the MORE requests will be logged. A
-       // sampling factor of 1 means log every request. This should not be
-       // lowered without careful coordination with ops.
-       $wgNavigationTimingSamplingFactor = 1000;
+       // Depends on EventLogging
+       if ( $wmgUseNavigationTiming ) {
+               wfLoadExtension( 'NavigationTiming' );
+               // Careful! The LOWER the value, the MORE requests will be 
logged. A
+               // sampling factor of 1 means log every request. This should 
not be
+               // lowered without careful coordination with ops.
+               $wgNavigationTimingSamplingFactor = 1000;
 
-       $wgPercentHHVM = 0;
+               $wgPercentHHVM = 0;
+       }
 }
 
 wfLoadExtension( 'XAnalytics' );

-- 
To view, visit https://gerrit.wikimedia.org/r/342147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f2fcdb3bda8448a499d2aeed62ca5b6f870eae
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Dereckson <dereck...@espace-win.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to