jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/326876 )
Change subject: API: Output real booleans for formatversion=2
......................................................................
API: Output real booleans for formatversion=2
...instead of the legacy empty strings. This is technically a breaking
change for formatversion=2 users, however I doubt it'll break any
clients since those that do something like `'private' in wikiinfo` will
still work.
Change-Id: I506226661c23803531cc26961ed08594a7b7ebf6
---
M SiteMatrixApi.php
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
Reedy: Looks good to me, approved
jenkins-bot: Verified
Anomie: Looks good to me, but someone else must approve
diff --git a/SiteMatrixApi.php b/SiteMatrixApi.php
index d25e465..85850e8 100644
--- a/SiteMatrixApi.php
+++ b/SiteMatrixApi.php
@@ -1,7 +1,7 @@
<?php
/**
- * Query module to get site matrix
+ * Module to get site matrix
* @ingroup API
*/
class ApiSiteMatrix extends ApiBase {
@@ -75,7 +75,7 @@
];
$site_out =
array_intersect_key( $site_out, $siteProp );
if ( $matrix->isClosed(
$lang, $site ) ) {
-
$site_out['closed'] = '';
+
$site_out['closed'] = true;
if ( $closed ) {
$skip =
false;
}
@@ -124,28 +124,28 @@
$skip = false;
}
if ( $matrix->isPrivate( $lang . $site ) ) {
- $wiki['private'] = '';
+ $wiki['private'] = true;
if ( $private ) {
$skip = false;
}
}
if ( $matrix->isFishbowl( $lang . $site ) ) {
- $wiki['fishbowl'] = '';
+ $wiki['fishbowl'] = true;
if ( $fishbowl ) {
$skip = false;
}
}
if ( $matrix->isNonGlobal( $lang . $site ) ) {
- $wiki['nonglobal'] = '';
+ $wiki['nonglobal'] = true;
if ( $nonglobal ) {
$skip = false;
}
}
if ( $matrix->isClosed( $lang, $site ) ) {
- $wiki['closed'] = '';
+ $wiki['closed'] = true;
if ( $closed ) {
$skip = false;
--
To view, visit https://gerrit.wikimedia.org/r/326876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I506226661c23803531cc26961ed08594a7b7ebf6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SiteMatrix
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
