Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/342195 )
Change subject: Connect inputs to onChangeHandler
......................................................................
Connect inputs to onChangeHandler
Bug: T160162
Change-Id: I7cd5e18326828ea7baf1a79f56f821ba83bfec8d
---
M modules/ve/node/ve.ui.MWPagesInspector.js
1 file changed, 12 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/95/342195/1
diff --git a/modules/ve/node/ve.ui.MWPagesInspector.js
b/modules/ve/node/ve.ui.MWPagesInspector.js
index a3c7816..e14e3e4 100644
--- a/modules/ve/node/ve.ui.MWPagesInspector.js
+++ b/modules/ve/node/ve.ui.MWPagesInspector.js
@@ -73,40 +73,40 @@
this.pushPending();
this.getFileInfo( attributes.index ).done( function ( imageInfo ) {
- inspector.addAttributeToWidget( inspector.createIndexWidget(),
'index' );
+ inspector.addAttributeWidgetToForm(
inspector.createIndexWidget(), 'index' );
- inspector.addAttributeToWidget( new OO.ui.DropdownInputWidget( {
+ inspector.addAttributeWidgetToForm( new
OO.ui.DropdownInputWidget( {
options: inspector.buildHeaderFieldSelectorOptions(
attributes.header )
} ), 'header' );
if ( imageInfo.pagecount !== undefined ) {
- inspector.addAttributeToWidget( new
OO.ui.NumberInputWidget( {
+ inspector.addAttributeWidgetToForm( new
OO.ui.NumberInputWidget( {
isInteger: true,
min: 1,
max: imageInfo.pagecount
} ), 'from' );
- inspector.addAttributeToWidget( new
OO.ui.NumberInputWidget( {
+ inspector.addAttributeWidgetToForm( new
OO.ui.NumberInputWidget( {
isInteger: true,
min: 1,
max: imageInfo.pagecount
} ), 'to' );
} else {
- inspector.addAttributeToWidget( new
mw.widgets.TitleInputWidget( {
+ inspector.addAttributeWidgetToForm( new
mw.widgets.TitleInputWidget( {
namespace: inspector.getIdForNamespace( 'page' )
} ), 'from' );
- inspector.addAttributeToWidget( new
mw.widgets.TitleInputWidget( {
+ inspector.addAttributeWidgetToForm( new
mw.widgets.TitleInputWidget( {
namespace: inspector.getIdForNamespace( 'page' )
} ), 'to' );
}
- inspector.addAttributeToWidget( new OO.ui.TextInputWidget(),
'fromsection' );
- inspector.addAttributeToWidget( new OO.ui.TextInputWidget(),
'tosection' );
+ inspector.addAttributeWidgetToForm( new
OO.ui.TextInputWidget(), 'fromsection' );
+ inspector.addAttributeWidgetToForm( new
OO.ui.TextInputWidget(), 'tosection' );
for ( key in attributes ) {
if ( key in inspector.attributeInputs ) {
inspector.attributeInputs[ key ].setValue(
attributes[ key ] );
} else {
- inspector.addAttributeToWidget( new
OO.ui.TextInputWidget( {
+ inspector.addAttributeWidgetToForm( new
OO.ui.TextInputWidget( {
value: attributes[ key ]
} ), key );
}
@@ -191,7 +191,7 @@
* @param {OO.ui.Widget} attributeInput
* @param {string} attributeKey the key of the attribute like "from"
*/
-ve.ui.MWPagesInspector.prototype.addAttributeToWidget = function (
attributeInput, attributeKey ) {
+ve.ui.MWPagesInspector.prototype.addAttributeWidgetToForm = function (
attributeInput, attributeKey ) {
var field = new OO.ui.FieldLayout(
attributeInput,
{
@@ -201,6 +201,7 @@
);
this.$attributes.append( field.$element );
this.attributeInputs[ attributeKey ] = attributeInput;
+ attributeInput.connect( this, { change: 'onChangeHandler' } );
};
/**
@@ -211,6 +212,7 @@
this.updateMwData( this.mwData );
this.teardownForm();
this.setupForm();
+ this.onChangeHandler();
}
};
--
To view, visit https://gerrit.wikimedia.org/r/342195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cd5e18326828ea7baf1a79f56f821ba83bfec8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
