Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/342255 )
Change subject: Prevent possible crash when rendering feed card.
......................................................................
Prevent possible crash when rendering feed card.
Within CardLargeHeaderView, we have a Runnable that doesn't check whether
the view is still attached to a window. If the view becomes detached, the
resulting animation will crash the app (I've just observed this by
scrolling the feed back and forth very quickly).
Change-Id: Ic1a40209189c905dea0f8c4d61cfe6412a674692
---
M app/src/main/java/org/wikipedia/feed/view/CardLargeHeaderView.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/55/342255/1
diff --git a/app/src/main/java/org/wikipedia/feed/view/CardLargeHeaderView.java
b/app/src/main/java/org/wikipedia/feed/view/CardLargeHeaderView.java
index 01ba8fa..3eec644 100644
--- a/app/src/main/java/org/wikipedia/feed/view/CardLargeHeaderView.java
+++ b/app/src/main/java/org/wikipedia/feed/view/CardLargeHeaderView.java
@@ -9,6 +9,7 @@
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v4.content.ContextCompat;
+import android.support.v4.view.ViewCompat;
import android.view.View;
import android.widget.RelativeLayout;
import android.widget.TextView;
@@ -61,6 +62,9 @@
post(new Runnable() {
@Override
public void run() {
+ if
(!ViewCompat.isAttachedToWindow(CardLargeHeaderView.this)) {
+ return;
+ }
animateBackgroundColor(CardLargeHeaderView.this,
mainColor);
if (faceLocation != null) {
imageView.getHierarchy().setActualImageFocusPoint(faceLocation);
--
To view, visit https://gerrit.wikimedia.org/r/342255
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1a40209189c905dea0f8c4d61cfe6412a674692
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
