jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342247 )
Change subject: DropdownInputWidget: Remove accidental patterned background in
PHP
......................................................................
DropdownInputWidget: Remove accidental patterned background in PHP
Change 2d5773a6bddf14f5dde412a4b9742b93e1c9a12d added
`class="oo-ui-indicator-down"` to DropdownInputWidget, so that
we could use it for a custom dropdown arrow in MediaWiki theme.
But that applies to other themes too and Apex doesn't have extra
CSS to make it work, resulting is a very funny effect. Disabled
PHP DropdownInputWidget in MediaWiki theme was also affected.
Change-Id: Id7fba53b4dc85904edc697940d9a52081187034c
---
M src/styles/widgets/DropdownInputWidget.less
M src/themes/mediawiki/widgets.less
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/styles/widgets/DropdownInputWidget.less
b/src/styles/widgets/DropdownInputWidget.less
index 032b74d..64eaf28 100644
--- a/src/styles/widgets/DropdownInputWidget.less
+++ b/src/styles/widgets/DropdownInputWidget.less
@@ -12,6 +12,10 @@
}
select {
+ // Hide the `background-image` from `.oo-ui-indicator-down` –
+ // themes can override `background-position` to display it.
+ background-position: -9999em 0;
+ background-repeat: no-repeat;
width: 100%;
cursor: pointer;
.oo-ui-box-sizing( border-box );
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 48b57b0..ab14595 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -570,8 +570,6 @@
&.oo-ui-widget-enabled {
select {
background-color: @background-color-framed;
- background-position: -9999em 0;
- background-repeat: no-repeat;
color: @color-default;
.oo-ui-transition(
background-color @transition-ease-quick,
--
To view, visit https://gerrit.wikimedia.org/r/342247
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7fba53b4dc85904edc697940d9a52081187034c
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
