[MediaWiki-commits] [Gerrit] mediawiki...BlogPage[master]: Migrate inline JS to appropriate script files

[SamanthaNguyen (Code Review)]

SamanthaNguyen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/342320 )

Change subject: Migrate inline JS to appropriate script files
......................................................................

Migrate inline JS to appropriate script files

Bug: T157246
Change-Id: Ic72e3f4cd4ed56f5f89b27f5062854bf15d21dee
---
M BlogPageClass.php
M extension.json
M resources/js/ext.blogpage.createblogpost.js
A resources/js/ext.blogpage.view.js
4 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlogPage 
refs/changes/20/342320/1

diff --git a/BlogPageClass.php b/BlogPageClass.php
index d300777..f4340a0 100644
--- a/BlogPageClass.php
+++ b/BlogPageClass.php
@@ -701,7 +701,7 @@
                $output .= '<div class="recent-container bottom-fix"><h2>' .
                        wfMessage( 'blog-embed-title' )->escaped() . '</h2>';
                $output .= '<div class="blog-widget-embed">';
-               $output .= "<p><input type='text' size='20' 
onclick='this.select();' value='" .
+               $output .= "<p><input type='text' size='20' value='" .
                        '<object width="300" height="450" id="content_widget" 
align="middle"> <param name="movie" value="content_widget.swf" /><embed src="' .
                        $wgServer . $wgScriptPath . 
'/extensions/ContentWidget/widget.swf?page=' .
                        urlencode( $title->getFullText() ) . '" quality="high" 
bgcolor="#ffffff" width="300" height="450" 
name="content_widget"type="application/x-shockwave-flash" /> </object>' . "' 
/></p></div>";
diff --git a/extension.json b/extension.json
index b383a5b..8fd815f 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
        "name": "BlogPage",
-       "version": "2.4.6",
+       "version": "2.4.7",
        "author": [
                "David Pean",
                "Jack Phoenix"
@@ -114,6 +114,9 @@
                                "blog-js-create-error-need-title",
                                "blog-js-create-error-page-exists"
                        ]
+               },
+               "ext.blogPage.view.js": {
+                       "scripts": "resources/js/ext.blogpage.view.js"
                }
        },
        "ResourceFileModulePaths": {
diff --git a/resources/js/ext.blogpage.createblogpost.js 
b/resources/js/ext.blogpage.createblogpost.js
index 5c9fccf..1ee967e 100644
--- a/resources/js/ext.blogpage.createblogpost.js
+++ b/resources/js/ext.blogpage.createblogpost.js
@@ -70,5 +70,9 @@
        $( 'input[name="wpSave"]' ).click( function() {
                CreateBlogPost.performChecks();
        } );
+
+       $( '.blog-widget-embed input' ).click( function() {
+               this.select();
+       } );
 } );
 }( mediaWiki, jQuery ) );
diff --git a/resources/js/ext.blogpage.view.js 
b/resources/js/ext.blogpage.view.js
new file mode 100644
index 0000000..20faaa8
--- /dev/null
+++ b/resources/js/ext.blogpage.view.js
@@ -0,0 +1,7 @@
+( function ( mw, $ ) {
+       $( function() {
+               $( '.blog-widget-embed input' ).click( function() {
+                       this.select();
+               } );
+       } );
+}( mediaWiki, jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/342320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic72e3f4cd4ed56f5f89b27f5062854bf15d21dee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlogPage
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen <samanthanguyen1...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits