Adamw has submitted this change and it was merged.
Change subject: campaign(s) bug.
......................................................................
campaign(s) bug.
TODO: parse banner names to determine what is being tested.
Change-Id: Ie55dd4ff1e3068874816177558238fbe5c04e417
---
M live_analysis/fr/tests/__init__.py
M live_analysis/fr/tests/spec_gdoc.py
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Adamw: Verified; Looks good to me, approved
diff --git a/live_analysis/fr/tests/__init__.py
b/live_analysis/fr/tests/__init__.py
index b82f36d..f0e5cc3 100644
--- a/live_analysis/fr/tests/__init__.py
+++ b/live_analysis/fr/tests/__init__.py
@@ -36,6 +36,9 @@
self.end_time = end
self.label = label
+ if not self.label:
+ # FIXME
+ self.label = campaign
self.enabled = not disabled
diff --git a/live_analysis/fr/tests/spec_gdoc.py
b/live_analysis/fr/tests/spec_gdoc.py
index e8ed0a8..6d130da 100644
--- a/live_analysis/fr/tests/spec_gdoc.py
+++ b/live_analysis/fr/tests/spec_gdoc.py
@@ -31,6 +31,6 @@
'type': "banner",
'start': test.start_time,
'end': test.end_time,
- 'campaigns': ", ".join([ c['name'] for c in test.campaigns ]),
+ 'campaign': test.campaign['name'],
'banners': ", ".join(test.banners),
})
--
To view, visit https://gerrit.wikimedia.org/r/51019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie55dd4ff1e3068874816177558238fbe5c04e417
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/tools
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
