Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/51023
Change subject: Changing flyout title to be a non-linking header per discussion
......................................................................
Changing flyout title to be a non-linking header per discussion
Having two links to the archive page is redundant and the meaning
of the title as a header for the list is lost.
Change-Id: I8dce36309e10854b9ff799c82501b6d59df0c621
---
M modules/overlay/ext.echo.overlay.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/23/51023/1
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index 09c0052..3c75298 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -87,7 +87,7 @@
} else {
titleText = mw.msg( 'echo-none'
);
}
- $title.html( $( '<a/>' ).attr( 'href',
mw.util.wikiGetlink( 'Special:Notifications' ) ).text( titleText ) );
+ $title.text( titleText );
$title.appendTo( $overlay );
if ( $ul.find( 'li' ).length ) {
--
To view, visit https://gerrit.wikimedia.org/r/51023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dce36309e10854b9ff799c82501b6d59df0c621
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
