Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/342668 )
Change subject: ext.navigationTiming: Move hoisted functions before statements
......................................................................
ext.navigationTiming: Move hoisted functions before statements
Makes code easier to follow. Especially with the early return
being added in the next commit.
Change-Id: I8c5bfe2aabf8a71fe7609ff918140a7efa2d4eb0
---
M modules/ext.navigationTiming.js
1 file changed, 31 insertions(+), 31 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/68/342668/1
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 03f22e5..c817f9d 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -12,37 +12,6 @@
visibilityChanged = false,
TYPE_NAVIGATE = 0;
- if ( window.performance ) {
- timing = performance.timing;
- navigation = performance.navigation;
- }
-
- // Don't report measurements for pages that have loaded in the
background.
- // Browsers defer or deprioritize loading background pages, causing
them to
- // take longer to load, which throws off our measurements.
- // See <https://phabricator.wikimedia.org/T146510#2794213> for more
details.
- if ( typeof document.hidden !== 'undefined' ) {
- hiddenProp = 'hidden';
- visibilityEvent = 'visibilitychange';
- } else if ( typeof document.mozHidden !== 'undefined' ) {
- hiddenProp = 'mozHidden';
- visibilityEvent = 'mozvisibilitychange';
- } else if ( typeof document.msHidden !== 'undefined' ) {
- hiddenProp = 'msHidden';
- visibilityEvent = 'msvisibilitychange';
- } else if ( typeof document.webkitHidden !== 'undefined' ) {
- hiddenProp = 'webkitHidden';
- visibilityEvent = 'webkitvisibilitychange';
- }
- if ( hiddenProp ) {
- $( document ).one( visibilityEvent, function () {
- visibilityChanged = true;
- } );
- if ( document[ hiddenProp ] ) {
- visibilityChanged = true;
- }
- }
-
function inSample() {
var factor = mw.config.get( 'wgNavigationTimingSamplingFactor'
);
if ( !$.isNumeric( factor ) || factor < 1 ) {
@@ -258,6 +227,37 @@
} );
}
+ if ( window.performance ) {
+ timing = performance.timing;
+ navigation = performance.navigation;
+ }
+
+ // Don't report measurements for pages that have loaded in the
background.
+ // Browsers defer or deprioritize loading background pages, causing
them to
+ // take longer to load, which throws off our measurements.
+ // See <https://phabricator.wikimedia.org/T146510#2794213> for more
details.
+ if ( typeof document.hidden !== 'undefined' ) {
+ hiddenProp = 'hidden';
+ visibilityEvent = 'visibilitychange';
+ } else if ( typeof document.mozHidden !== 'undefined' ) {
+ hiddenProp = 'mozHidden';
+ visibilityEvent = 'mozvisibilitychange';
+ } else if ( typeof document.msHidden !== 'undefined' ) {
+ hiddenProp = 'msHidden';
+ visibilityEvent = 'msvisibilitychange';
+ } else if ( typeof document.webkitHidden !== 'undefined' ) {
+ hiddenProp = 'webkitHidden';
+ visibilityEvent = 'webkitvisibilitychange';
+ }
+ if ( hiddenProp ) {
+ $( document ).one( visibilityEvent, function () {
+ visibilityChanged = true;
+ } );
+ if ( document[ hiddenProp ] ) {
+ visibilityChanged = true;
+ }
+ }
+
// Ensure we run after loadEventEnd.
onLoadComplete( function () {
if ( inSample() && !visibilityChanged ) {
--
To view, visit https://gerrit.wikimedia.org/r/342668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c5bfe2aabf8a71fe7609ff918140a7efa2d4eb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
