jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342651 )
Change subject: Update VE core submodule to master (41134af2b) ...................................................................... Update VE core submodule to master (41134af2b) New changes: 1e12d0174 Generalize DiffElement logic (improves lists and tables) 24e0c7a94 Localisation updates from https://translatewiki.net. 32759ae86 Allow variable-length sequences without a fake space terminator, use for autolinking 82c204ba0 QUnit.assert.equalHash: Correctly compare JSON representation 2e5462610 DiffElement: Allow a node change to be an attribute change *and* a linear diff 41134af2b ve.ui.LinkAction: Allow autolinking ranges including trailing spaces again Local changes: Updated tests for 32759ae86: the autolinkUrl command no longer expects trailing whitespace to be included in the range. Bug: T117165 Bug: T149537 Bug: T158518 Change-Id: I5c2d5b97894fc93f49ce6270a198f3dfdcd09986 --- M lib/ve M modules/ve-mw/tests/ui/actions/ve.ui.MWLinkAction.test.js 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/ve b/lib/ve index bc0001c..41134af 160000 --- a/lib/ve +++ b/lib/ve @@ -1 +1 @@ -Subproject commit bc0001c53ed16e663adccc9991a1ed69ab3b6bb1 +Subproject commit 41134af2b6aa511b56459f05cc6d4c0e512d7afe diff --git a/modules/ve-mw/tests/ui/actions/ve.ui.MWLinkAction.test.js b/modules/ve-mw/tests/ui/actions/ve.ui.MWLinkAction.test.js index 7d03367..8b75887 100644 --- a/modules/ve-mw/tests/ui/actions/ve.ui.MWLinkAction.test.js +++ b/modules/ve-mw/tests/ui/actions/ve.ui.MWLinkAction.test.js @@ -15,9 +15,9 @@ { msg: 'Strip trailing punctuation (but not matched parens)', html: '<p><b>https://en.wikipedia.org/wiki/Red_(disambiguation) xyz</b></p>', - rangeOrSelection: new ve.Range( 1, 52 ), + rangeOrSelection: new ve.Range( 1, 51 ), method: 'autolinkUrl', - expectedRangeOrSelection: new ve.Range( 52 ), + expectedRangeOrSelection: new ve.Range( 51 ), expectedData: function ( data, action ) { var i, a = action.getLinkAnnotation( 'https://en.wikipedia.org/wiki/Red_(disambiguation)' ); @@ -31,7 +31,7 @@ html: '<p><b>RFC 1234 xyz</b></p>', rangeOrSelection: new ve.Range( 1, 10 ), method: 'autolinkMagicLink', - expectedRangeOrSelection: new ve.Range( 4, 4 ), + expectedRangeOrSelection: new ve.Range( 4 ), expectedOriginalRangeOrSelection: new ve.Range( 10 ), expectedData: function ( data ) { data.splice( 1, 8, { -- To view, visit https://gerrit.wikimedia.org/r/342651 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c2d5b97894fc93f49ce6270a198f3dfdcd09986 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester <[email protected]> Gerrit-Reviewer: Bartosz Dziewoński <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
