Mobrovac has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/340264 )
Change subject: Update node-rdkafka to 0.8.0
......................................................................
Update node-rdkafka to 0.8.0
Bug: T159200
Change-Id: I502c77ed65b453cd44c45a527d253559dff448c0
---
M lib/edit-stream.js
M package.json
M spec.yaml
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mobrovac: Verified; Looks good to me, approved
diff --git a/lib/edit-stream.js b/lib/edit-stream.js
index ea5d0a5..2c82247 100644
--- a/lib/edit-stream.js
+++ b/lib/edit-stream.js
@@ -90,7 +90,8 @@
this._consumer.connect();
this._consumer
.on('ready', () => {
- this._consumer.consume(this._consumeTopics, (e, kafkaMessage) => {
+ this._consumer.subscribe(this._consumeTopics);
+ this._consumer.consume(undefined, (e, kafkaMessage) => {
if (e) {
return this.emit('error', e);
}
diff --git a/package.json b/package.json
index fe01927..534da59 100644
--- a/package.json
+++ b/package.json
@@ -33,7 +33,7 @@
"preq": "^0.4.10",
"service-runner": "^2.1.10",
"swagger-router": "^0.4.6",
- "node-rdkafka": "^0.6.2",
+ "node-rdkafka": "^0.8.0",
"wikipedia-edits-scorer": "^1.4.0"
},
"devDependencies": {
diff --git a/spec.yaml b/spec.yaml
index b273549..1265855 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -74,7 +74,6 @@
body:
pages: []
timestamp: /.+/
- body:
- title: get trending articles from en.wp.org
response:
status: 200
--
To view, visit https://gerrit.wikimedia.org/r/340264
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I502c77ed65b453cd44c45a527d253559dff448c0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Ppchelko <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
