jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/342824 )

Change subject: Remove MSIE from blacklist, already blacklisted upstream
......................................................................


Remove MSIE from blacklist, already blacklisted upstream

We support all versions of IE that MW supports, so no need
for additional blacklisting.

Bug: T160494
Change-Id: I771459b4d6a0e2d5781a69a905a51323369b3b66
---
M extension.json
M modules/ve-mw/tests/init/targets/ve.init.mw.DesktopArticleTarget.test.js
2 files changed, 0 insertions(+), 16 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/extension.json b/extension.json
index 5a1259b..cc5b54b 100644
--- a/extension.json
+++ b/extension.json
@@ -58,12 +58,6 @@
                "VisualEditorShowBetaWelcome": true,
                "VisualEditorParsoidHTTPProxy": false,
                "VisualEditorBrowserBlacklist": {
-                       "msie": [
-                               [
-                                       "<=",
-                                       8
-                               ]
-                       ],
                        "android": [
                                [
                                        "<",
diff --git 
a/modules/ve-mw/tests/init/targets/ve.init.mw.DesktopArticleTarget.test.js 
b/modules/ve-mw/tests/init/targets/ve.init.mw.DesktopArticleTarget.test.js
index de4d828..4e162bc 100644
--- a/modules/ve-mw/tests/init/targets/ve.init.mw.DesktopArticleTarget.test.js
+++ b/modules/ve-mw/tests/init/targets/ve.init.mw.DesktopArticleTarget.test.js
@@ -16,16 +16,6 @@
                                matches: []
                        },
                        {
-                               msg: 'IE7',
-                               userAgent: 'Mozilla/4.0 (compatible; MSIE 7.0b; 
Windows NT 6.0)',
-                               matches: [ 'blacklist' ]
-                       },
-                       {
-                               msg: 'IE8',
-                               userAgent: 'Mozilla/5.0 (compatible; MSIE 8.0; 
Windows NT 5.2; Trident/4.0)',
-                               matches: [ 'blacklist' ]
-                       },
-                       {
                                msg: 'IE9',
                                userAgent: 'Mozilla/5.0 (Windows; U; MSIE 9.0; 
Windows NT 9.0; en-US)',
                                matches: []

-- 
To view, visit https://gerrit.wikimedia.org/r/342824
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I771459b4d6a0e2d5781a69a905a51323369b3b66
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to