jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342871 )
Change subject: MWAceEditorWidget: Fix position of ace tooltip
......................................................................
MWAceEditorWidget: Fix position of ace tooltip
The floating tooltip breaks inside OOUI dialogs. In the absence
of an upstream fix, just anchor it to the bottom of the textbox.
Bug: T160245
Change-Id: I9055c4e4947f5581605bd490f076415c1edaf8ec
---
M modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
index d41d8c8..6b10dbf 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css
@@ -12,6 +12,17 @@
font-family: monospace, 'Courier';
font-size: inherit;
line-height: 1.5;
+ /* Allow tooptip outside of editor */
+ overflow: visible;
+}
+
+.ve-ui-mwAceEditorWidget .ace_tooltip {
+ /* Make tooltip into status bar, as position is broken in Ace */
+ top: auto !important; /* stylelint-disable-line
declaration-no-important */
+ bottom: -23px !important; /* stylelint-disable-line
declaration-no-important */
+ left: 0 !important; /* stylelint-disable-line declaration-no-important
*/
+ white-space: pre-wrap;
+ position: absolute;
}
.ve-ui-mwAceEditorWidget .ace_focus {
--
To view, visit https://gerrit.wikimedia.org/r/342871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9055c4e4947f5581605bd490f076415c1edaf8ec
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
